From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26452 invoked by alias); 24 Aug 2012 22:30:49 -0000 Received: (qmail 26440 invoked by uid 22791); 24 Aug 2012 22:30:48 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,URIBL_DBL_REDIR X-Spam-Check-By: sourceware.org Received: from mail-gh0-f197.google.com (HELO mail-gh0-f197.google.com) (209.85.160.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 22:30:31 +0000 Received: by ghbf15 with SMTP id f15so3162160ghb.8 for ; Fri, 24 Aug 2012 15:30:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.70.146 with SMTP id m18mr2248522veu.0.1345847429990; Fri, 24 Aug 2012 15:30:29 -0700 (PDT) Reply-To: cmang@google.com, tejohnson@google.com, xur@google.com, davidxl@google.com, gcc-patches@gcc.gnu.org, reply@codereview-hr.appspotmail.com X-Google-Appengine-App-Id: s~codereview-hr Message-ID: <047d7b5da8f1fc8b2e04c80a855d@google.com> Date: Fri, 24 Aug 2012 22:30:00 -0000 Subject: Re: [google] Modification of gcov pmu format to reduce gcda size bloat (issue 6427063) From: davidxl@google.com To: cmang@google.com, tejohnson@google.com, xur@google.com Cc: gcc-patches@gcc.gnu.org, reply@codereview-hr.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-08/txt/msg01710.txt.bz2 http://codereview.appspot.com/6427063/diff/11002/gcc/gcov-io.h File gcc/gcov-io.h (right): http://codereview.appspot.com/6427063/diff/11002/gcc/gcov-io.h#newcode688 gcc/gcov-io.h:688: gcov_unsigned_t index; /* The corresponding string table index */ Is this field necessary? http://codereview.appspot.com/6427063/diff/11002/gcc/gcov-io.h#newcode689 gcc/gcov-io.h:689: char* filename; /* The filename that belongs at this index */ Can this field name be generalized? http://codereview.appspot.com/6427063/diff/11002/libgcc/pmu-profile.c File libgcc/pmu-profile.c (right): http://codereview.appspot.com/6427063/diff/11002/libgcc/pmu-profile.c#newcode83 libgcc/pmu-profile.c:83: Who is the caller to this interface? It should be declared in gcov-io.h http://codereview.appspot.com/6427063/