From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 7F608388983E for ; Fri, 11 Jun 2021 14:47:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F608388983E Received: by mail-ot1-x336.google.com with SMTP id 36-20020a9d0ba70000b02902e0a0a8fe36so3359530oth.8 for ; Fri, 11 Jun 2021 07:47:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ekgTEF3Wqj1pVTb6U1sdN1c890X8VjlwXdLWT+/W0AE=; b=ueMSNmC4BdSTiFiCoQWJpGJRodT3X7KkvTAhRuoQWqBwjW9gC6GU3jKgL7QjImYcXy YSHc5JpWo+bSDa3mVj1HdAnMOaFksIyvNOzc1JCkkk4Fper8BWj7Xf7ZPB3a1D+iqJsV CEEDvF/SJYuFZxFQ3XuwcrfNnE87bRR9xDqFLGi4/xhRYkntWCQ/SO8+BlEYD0M4AQxa 01m0cO7z4pJYe2aKIPxMGYDEgIj1Z+J/UzuHrV1Jrj2lrHybSRi6bKfICHWX7VieVsx1 7BFwgElFeKocvRTDVGYBOAjPLbw7kQOwJzjdSGE+BiNECAf0eFlMl0BssL5ZZbEcgR6Z QyNA== X-Gm-Message-State: AOAM5320L/26s9XxEwZDSm1QfWQW090USYSewmGGd7sZNz8b/MD2Zynk LYb2RFmsz0lI4SIbR0HCYOPUnuE9r3k= X-Google-Smtp-Source: ABdhPJxRzzqN7/O6/cVib9kmsxPBv9C8iKNFraNbR7CDA21bDGT0jSXa39rjPfBq82U6FbIka9bvIQ== X-Received: by 2002:a9d:4817:: with SMTP id c23mr3576520otf.352.1623422845797; Fri, 11 Jun 2021 07:47:25 -0700 (PDT) Received: from [192.168.0.41] (97-118-122-241.hlrn.qwest.net. [97.118.122.241]) by smtp.gmail.com with ESMTPSA id 7sm1151997oor.30.2021.06.11.07.47.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 07:47:25 -0700 (PDT) Subject: Re: [PATCH 3/4] remove %K from error() calls in the aarch64/arm back ends (PR 98512) To: Christophe Lyon Cc: gcc-patches References: <2e49b6c6-a403-a207-c41e-58f78df96b84@gmail.com> <945093c7-de5e-0350-6030-e4e79ea41161@gmail.com> <5aff247f-dfcb-cecf-e07e-b5fca877f911@gmail.com> <24e1d1ea-33a0-bab8-3182-1dbb90ff7e3c@gmail.com> From: Martin Sebor Message-ID: <048f9a77-6aee-fca8-1064-dd11f87ffbf7@gmail.com> Date: Fri, 11 Jun 2021 08:47:24 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 14:47:27 -0000 On 6/11/21 7:10 AM, Christophe Lyon wrote: > On Fri, 11 Jun 2021 at 09:53, Christophe Lyon > wrote: >> >> On Fri, 11 Jun 2021 at 01:29, Martin Sebor via Gcc-patches >> wrote: >>> >>> This patch removes the uses of %K from error() calls in the aarch64 >>> and arm back ends. I tested this change only by building a cross- >>> compiler but I can't easily run the tests so I'd appreciate some help >>> validating it. The fallout from the change should be limited to changes >>> to error messages so in the worst case it could be addressed after >>> committing the patch. >> >> I've submitted a validation with your patch, I'll let you know the >> results (in a few hours) >> > > I haven't noticed any regression with that patch alone. > I just noticed it is patch 3/4: I didn't apply patches 1 and 2 before > this one, do you want me to relaunch the tests with the 3 patches > combined? That would be great, as soon as I fix the thinko Richard Sandiford pointed out. Thanks for the offer! Martin > > Thanks, > > Christophe > >> Thanks >> >> Christophe