From: Jason Merrill <jason@redhat.com>
To: Patrick Palka <ppalka@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 2/3] c++: remember candidates that we ignored
Date: Tue, 24 Oct 2023 17:51:53 -0400 [thread overview]
Message-ID: <0497781f-8b5c-4915-b77b-4efd2b0a5bd8@redhat.com> (raw)
In-Reply-To: <20231023235154.2971561-2-ppalka@redhat.com>
On 10/23/23 19:51, Patrick Palka wrote:
> During overload resolution, we sometimes outright ignore a function from
> the overload set and leave no trace of it in the candidates list, for
> example when we find a perfect non-template candidate we discard all
> function templates, or when the callee is a template-id we discard all
> non-template functions. We should still however make note of these
> unviable functions when diagnosing overload resolution failure, but
> that's not possible if they're not present in the returned candidates
> list.
>
> To that end, this patch reworks add_candidates to add such ignored
> functions to the list. The new rr_ignored rejection reason is somewhat
> of a catch-all; we could perhaps split it up into more specific rejection
> reasons, but I leave that as future work.
OK with the same unviable -> non-viable change as the 1/3 patch.
Jason
next prev parent reply other threads:[~2023-10-24 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 23:51 [PATCH v2 1/3] c++: sort candidates according to viability Patrick Palka
2023-10-23 23:51 ` [PATCH v2 2/3] c++: remember candidates that we ignored Patrick Palka
2023-10-24 21:51 ` Jason Merrill [this message]
2023-10-23 23:51 ` [PATCH v2 3/3] c++: note other candidates when diagnosing deletedness Patrick Palka
2023-10-24 21:56 ` Jason Merrill
2023-10-24 21:28 ` [PATCH v2 1/3] c++: sort candidates according to viability Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0497781f-8b5c-4915-b77b-4efd2b0a5bd8@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).