From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3943F3858CDA for ; Tue, 24 Oct 2023 21:51:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3943F3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3943F3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698184318; cv=none; b=ny+sFwi+rd9DwB4CGhnZEKJS4CKJ8pDk/NpKDq7O0DKaTkkkDsdatPT2JCCH3QLL8JAsdW78reWIt7AAasMu7nRXnYf9P+Wca0bq7yrXn+58STFrwnPYs1Z7eAj4TDt+4JG8JfEfrNjLKeVw3EIQHgbnN0WnrM5V8f0NNpSKAyE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698184318; c=relaxed/simple; bh=K8nEz35zbWbmEooEtLoDQPjC3vfyme4fwIkmdDMOXpc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wu3Jb3jt5FmHN6iLpDURMCsKqeOvn5WqFXZaHh3ZZQlQMjwkz2J6jreXlAXwXDSDbms70RHZkX7qbFye/By8La9dFsV4EuZbRrxLUklNWoQb/3tqmkv5RYFW/QmHboOqWlo/aoI4eWKKelzhV4iymLBCtXXmf66oO7vz/Gzhe3Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698184316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kio+RVp+ZBuTUNYdKUP5PHfRBQW+n1IW+PK/efpY9f8=; b=U7KGLbVfeM3Ie9SCPXhsGRbrv7b920JWc1IVjlmbyG4nHuTF8HqXnI535vp8UPw5ePECgx C5camVH/CrfslbD1xKr+MqWBQjZiHmt1iqsEVkMHA2B3e2CUEg53VApRFEbTIyEaZcIEFQ b+P4dLrVMz5QjKsyhdEtjdRriI0QTA0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-aLC9xcjmMSCmijWF0D2DXg-1; Tue, 24 Oct 2023 17:51:55 -0400 X-MC-Unique: aLC9xcjmMSCmijWF0D2DXg-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-66d0ceb78cbso60989956d6.1 for ; Tue, 24 Oct 2023 14:51:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698184315; x=1698789115; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kio+RVp+ZBuTUNYdKUP5PHfRBQW+n1IW+PK/efpY9f8=; b=iN3P+7AYPSIVMxViZyCyBKcDcWpS58Qe0NwHQgsXpOrFG3txgMsSxF4n+Az0gohf4a FOxpVVYdspUV5UnAdZq27Co9Ad+ROgGxeI19qFZnZRnmpWi3Vc9VO+xJi8yNf2guCW35 SFgfa1zKkWJ5QBXNqxwVZue0RMyPY4mqVXv0/iX6ODp6fwhKKOGAxx8IJv9rFGH9UkcC hzdvH6JPKqH2ch6moz1JnTzeu1GAsV8srUwJt0ffeLHLBXnmIVP5MGGH8mhobVweOcI5 2n0knHv4uvfeplRAqrS56MpLd5iB6Q0Fij7YQHjWXJXWl2e6NVNv5+fTyC5/LTRdmyv8 SYjQ== X-Gm-Message-State: AOJu0YxWhJRtOat3qjtKMlWT/twMTi/hyZzg+ReRUNQ3IWCws2ws/46r lSY2sfUn+y9GdX0QCtrgRlHmjHnojepSh2ZnCsU7qqeIvShQiR9V8RD5fxuHhzjiEdWIQ1yUSK/ zQyHMVcR30ttIag5p2g== X-Received: by 2002:a05:6214:2583:b0:66d:bc21:814c with SMTP id fq3-20020a056214258300b0066dbc21814cmr8847369qvb.65.1698184314892; Tue, 24 Oct 2023 14:51:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwwaYHqTfdzo4efx7g0jfLZ8COQZ0MrXeKmyNtBey8Htl1R7DMra3OHmG5sfikbotX9u6Bxw== X-Received: by 2002:a05:6214:2583:b0:66d:bc21:814c with SMTP id fq3-20020a056214258300b0066dbc21814cmr8847356qvb.65.1698184314606; Tue, 24 Oct 2023 14:51:54 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id w10-20020ac84d0a000000b0041803dfb240sm3768220qtv.45.2023.10.24.14.51.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Oct 2023 14:51:54 -0700 (PDT) Message-ID: <0497781f-8b5c-4915-b77b-4efd2b0a5bd8@redhat.com> Date: Tue, 24 Oct 2023 17:51:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] c++: remember candidates that we ignored To: Patrick Palka , gcc-patches@gcc.gnu.org References: <20231023235154.2971561-1-ppalka@redhat.com> <20231023235154.2971561-2-ppalka@redhat.com> From: Jason Merrill In-Reply-To: <20231023235154.2971561-2-ppalka@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/23/23 19:51, Patrick Palka wrote: > During overload resolution, we sometimes outright ignore a function from > the overload set and leave no trace of it in the candidates list, for > example when we find a perfect non-template candidate we discard all > function templates, or when the callee is a template-id we discard all > non-template functions. We should still however make note of these > unviable functions when diagnosing overload resolution failure, but > that's not possible if they're not present in the returned candidates > list. > > To that end, this patch reworks add_candidates to add such ignored > functions to the list. The new rr_ignored rejection reason is somewhat > of a catch-all; we could perhaps split it up into more specific rejection > reasons, but I leave that as future work. OK with the same unviable -> non-viable change as the 1/3 patch. Jason