From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [IPv6:2001:67c:2050:1::465:107]) by sourceware.org (Postfix) with ESMTPS id 58AD8385DC1A for ; Tue, 7 Apr 2020 16:26:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 58AD8385DC1A Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 48xXpS0JxqzKpKj; Tue, 7 Apr 2020 18:26:08 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id YLkUXsqTxVId; Tue, 7 Apr 2020 18:26:03 +0200 (CEST) Subject: Re: [PATCH] S/390: Fix PR91628 To: Stefan Liebler , GCC Patches References: <0afe1b58-2544-98c2-b056-a724f1a5fa6d@linux.ibm.com> <349a43fc-2a10-19ee-c7f0-ee18b29722e4@linux.ibm.com> <15b5b45f-de91-91df-3fb7-3befc0a6ffa4@gdcproject.org> <8c0973a2-58c6-fb2b-9511-406047001639@linux.ibm.com> From: Iain Buclaw Message-ID: <04fb9684-911e-939d-1640-6d149968c17e@gdcproject.org> Date: Tue, 7 Apr 2020 18:26:01 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CB41E1782 X-Rspamd-Score: -4.59 / 15.00 / 15.00 X-Spam-Status: No, score=-15.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 16:26:11 -0000 On 07/04/2020 16:33, Stefan Liebler wrote: > On 4/1/20 6:20 PM, Stefan Liebler wrote: >> On 4/1/20 12:50 PM, Iain Buclaw wrote: >>> >>> >>> On 01/04/2020 08:28, Stefan Liebler wrote: >>>> ping >>>> >>> >>> Hi Stefan, >>> >>> As I've already said, I think that the name should be __ibmz_get_tls_offset to make clear that it is an internal function. >>> >>> Other than that, looks good to me. >>> >>> Iain. >>> >> >> Hi Iain, >> >> Sorry. I've missed your comment in the bugzilla. >> I've updated the name to __ibmz_get_this_offset. >> Nothing else is changed in the attached patch. >> >> Please commit the patch upstream. >> Do you also close the bugzilla as soon as committed? >> >> Regarding the mentioned musl-patch in your bugzilla comment: >> Yes, the diff looks like not conflicting. >> >> Thanks, >> Stefan > > Hi Iain, > > Andreas has just committed the other patch "S/390: Fix layout of struct sigaction_t" to gcc after your pull-request was merged (https://github.com/dlang/druntime/pull/3020). > > To me it seems that this patch is not simply pull-request-able to https://github.com/dlang/druntime. Correct, all sources touched are local to gcc only. > As you've already mentioned "Other than that, looks good to me.", is this gcc patch okay to commit from your side? Then Andreas can also commit it and we can close the bugzilla. > No problems with it being committed. Regards Iain.