From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 8AB923858D1E for ; Sat, 11 Mar 2023 17:31:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AB923858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52a.google.com with SMTP id d6so4808527pgu.2 for ; Sat, 11 Mar 2023 09:31:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678555877; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hKQNJP36tSosRq3ObHYzNT4s18RbsNPo1VWm+YKZ7Ug=; b=hwNvr2FL4pyvYLbG2LTtdtO9aAxtM02WANNxg47qGg0Ojy2Hxj4ulYMRBa4k9Z01pU Tw6th1V4XbW7GrfxvCvWUYgEnyk8PSGwtSb3qg9udijT4O70exU2SJgdOHOP6m0uCDC5 N0if/fM6b/JRtc28lo9AbnOhcYZA0TJLAUKd0BQBVSu5cn4AkdourOUKZ7E7GbL8lBAu ynZwGPD2bOblj487f68/twUMa+Vi6yvr1Qzfw7pexMQwINVrQxlw7St7wEWGNrA1ygeI dinXd7CdLszAAMqEl7g3xSFTHJ9NfVqVlDo4zmO992cUNeCqbiIwFJKmp6hXfnWicVbE eCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678555877; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hKQNJP36tSosRq3ObHYzNT4s18RbsNPo1VWm+YKZ7Ug=; b=1NecsSiFmlb2iewug11RQ598MoYWhsI1XJW9OX9IN5/QuWF2tSfxzyWXbLmAoId4ja /FHdPN8CSJaorJxKQoyf3v/kLduSWX5IChuX5rJ1fvhivgiVlQUjo8XeIaWvbN08k+gr lru86E8g9gKuOfJIqdFFzcTXFPRKY/YSaAuDltqjO6q9MOlpFSWbs4oka7qktGMcfPjs gH4ufXW7aEYaE00qiLDFnhvzyClxNtOeilh5GvvwskXlQMQ/5ZmEXdsSERHr49zl2V3Q SE0AERjCOcjSwpajFcYRkKUHLUD/FCHtFDt+DAj6Jt042EO1Vf8jSmbd97XP+9UeLEGh +Oig== X-Gm-Message-State: AO0yUKV5j7YkJ+b9qP4mIyVwUfJKsQyXvS0hql6l6joQVKS3++rQ+EY5 cxlCneBmhON07B5CHFPF6TE= X-Google-Smtp-Source: AK7set8XjdAsUJ42C87HanCePfV6jFKQj/QuBHPTY82xH6Mf8GBnk/ckRODB9ZnUKE73c/C6ScEz8Q== X-Received: by 2002:a62:1b86:0:b0:5a8:cb5f:94d4 with SMTP id b128-20020a621b86000000b005a8cb5f94d4mr21103916pfb.32.1678555877447; Sat, 11 Mar 2023 09:31:17 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id d25-20020aa78699000000b0061ddff8c53dsm1711369pfo.151.2023.03.11.09.31.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 09:31:17 -0800 (PST) Message-ID: <05375b8f-644f-3f53-4fd9-992267910d64@gmail.com> Date: Sat, 11 Mar 2023 10:31:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] libcpp: Update to Unicode 15 Content-Language: en-US To: Lewis Hyatt , gcc-patches@gcc.gnu.org Cc: Jakub Jelinek References: <20230309232746.GA8644@ldh-imac.local> From: Jeff Law In-Reply-To: <20230309232746.GA8644@ldh-imac.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/9/23 16:27, Lewis Hyatt via Gcc-patches wrote: > On Fri, Nov 04, 2022 at 10:03:13AM +0100, Jakub Jelinek via Gcc-patches wrote: >> Hi! >> >> The following pseudo-patch (for uname2c.h part >> just a pseudo patch with a lot of changes replaced with ... >> because it is too large but the important changes like >> -static const char uname2c_dict[59418] = >> +static const char uname2c_dict[59891] = >> -static const unsigned char uname2c_tree[208765] = { >> +static const unsigned char uname2c_tree[210697] = { >> are shown, full patch xz compressed will be posted separately >> due to mail limit) regenerates the libcpp tables with Unicode 15.0.0 >> which added 4489 new characters. >> >> As mentioned previously, this isn't just a matter of running the >> two libcpp/make*.cc programs on the new Unicode files, but one needs >> to manually update a table inside of makeuname2c.cc according to >> a table in Unicode text (which is partially reflected in the text >> files, but e.g. in Unicode 14.0.0 not 100% accurately, in 15.0.0 >> actually accurately). >> I've also added some randomly chosen subset of those 4489 new >> characters to a testcase. >> >> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > Hi Jakub- > > In addition to these files you updated last year for Unicode 15, we also need > to update generated_cpp_wcwidth.h, which implements cpp_wcwidth() for > diagnostics so we can output correct column numbers. There is a procedure > outlined in the file contrib/unicode/README that accomplishes this. Is it OK > to push the attached patch (gzipped since it is large and uninformative), > which is the result of following the procedure? It went straightforwardly as > expected, and bootstrap+regtest on x86-64 Linux is clean. Thanks! Yes, please go ahead and push it. jeff