From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26767 invoked by alias); 9 Oct 2007 04:30:14 -0000 Received: (qmail 26754 invoked by uid 22791); 9 Oct 2007 04:30:14 -0000 X-Spam-Check-By: sourceware.org Received: from mail-out3.apple.com (HELO mail-out3.apple.com) (17.254.13.22) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Oct 2007 04:30:10 +0000 Received: from relay14.apple.com (relay14.apple.com [17.128.113.52]) by mail-out3.apple.com (Postfix) with ESMTP id 6541A149F4A5; Mon, 8 Oct 2007 21:30:09 -0700 (PDT) Received: from relay14.apple.com (unknown [127.0.0.1]) by relay14.apple.com (Symantec Mail Security) with ESMTP id 4400528087; Mon, 8 Oct 2007 21:30:09 -0700 (PDT) X-AuditID: 11807134-a7696bb000000861-d1-470b03d0ede1 Received: from [17.151.104.45] (unknown [17.151.104.45]) by relay14.apple.com (Apple SCV relay) with ESMTP id C0FD128053; Mon, 8 Oct 2007 21:30:08 -0700 (PDT) In-Reply-To: <470ACCBE.5010509@codesourcery.com> References: <20071004212317.7FA2C7771263@geoffk5.apple.com> <200710071130.25478.ebotcazou@adacore.com> <470AAED9.9010207@codesourcery.com> <200710090220.10904.ebotcazou@adacore.com> <470ACCBE.5010509@codesourcery.com> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: multipart/signed; micalg=sha1; boundary=Apple-Mail-1-996128202; protocol="application/pkcs7-signature" Message-Id: <05DDE86C-505D-46FD-9594-C11331D0D4BA@apple.com> Cc: Eric Botcazou , Daniel Jacobowitz , gcc-patches List , Andrew Haley From: Geoffrey Keating Subject: Re: Don't set DECL_IGNORED_P on a cdtor function Date: Tue, 09 Oct 2007 04:30:00 -0000 To: Mark Mitchell X-Mailer: Apple Mail (2.752.2) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-10/txt/msg00458.txt.bz2 --Apple-Mail-1-996128202 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-length: 1271 On 08/10/2007, at 5:35 PM, Mark Mitchell wrote: > Eric Botcazou wrote: > >>> The key issues are that (a) we have no source for these >>> compiler-generated functions, and (b) they don't correspond to >>> anything >>> in the source program. If I say "step" off the end of a C++ >>> "main", I >>> don't want to end up in one of these functions; I want to end up >>> in the >>> first C++ destructor being called by them. That's the C++ view >>> of the >>> world; these cdtor functions are just implementation details. >>> >>> So, I think we should consider the issue closed, with Eric's patch. >> >> Your comment seems to imply that Geoff's patch should be reverted >> too. :-) > > Yes, I do. (I hadn't realized it had been committed.) > > Does anyone concur? Object? The entire paragraph under 'Eric Botcazou wrote' lists reasons why my patch is correct. "(a)": well, if you don't have source, tell the debugger that, rather than having the debugger associate it with the last line in the previous function. "(b)": this is what DECL_ARTIFICIAL is for, but it has no effect if there's no debug information. "If I say "step" off the end of a C++ "main", I don't want to end up in one of these functions": yes, that's what DECL_ARTIFICIAL is for. --Apple-Mail-1-996128202 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s Content-length: 3339 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEH AQAAoIIGUDCCAwkwggJyoAMCAQICEFT8y6jYgKvbR4T8stEWA9wwDQYJKoZI hvcNAQEFBQAwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25z dWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBG cmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MDUyMzAyNDczMloXDTA4MDUyMjAy NDczMlowcTEQMA4GA1UEBBMHS2VhdGluZzEZMBcGA1UEKhMQR2VvZmZyZXkg RnJhbmNpczEhMB8GA1UEAxMYR2VvZmZyZXkgRnJhbmNpcyBLZWF0aW5nMR8w HQYJKoZIhvcNAQkBFhBnZW9mZmtAYXBwbGUuY29tMIIBIjANBgkqhkiG9w0B AQEFAAOCAQ8AMIIBCgKCAQEA6df0ovUQkLAc+KBjPe4Jaa+EwIu5yXmTpZ/4 eCwNJu0BuYZU2Or3bW0Ue9Sh3AjYGDGDMWJr/GR3mqmQdcJuXuXwviGgPECA 6QAmV2XsjZU5cckBpdhvUajPwZkt3xK67YwXyl8RiBIEzX1ze5EkQwCl/lbI OLc7HiRT9U2jSvxXfWF3es97TNJSy3kW2EXy6KGUQZj/ijhCMCLCUh28df8x 6q6oeouX0HC9ItOu66C0baImZ+KYkNg17O/WwIBC3Q45Y7cYWM2EgdfeUiOm thXw0gRpLo3848Aee/eTZEOQQo9cDrrbUn5UQYG3p0wAOP4EPzCS6WsEFyrR 4E9B9wIDAQABoy0wKzAbBgNVHREEFDASgRBnZW9mZmtAYXBwbGUuY29tMAwG A1UdEwEB/wQCMAAwDQYJKoZIhvcNAQEFBQADgYEAcQnpwjNKwn36pGia5wyl 4jo2Yg3iALqw8Yo8YNHke+f916PpSgJrm0NuKZFGQaTouHr6h5PCLx+9/jGi 35iYPgrxuNI2DNeYzPXSUQgPnlBCp+GA1tjlOP24l1U1Q+m/nzgMDEHF9+/W Mn9ZyMlqcTLfYggDSZWQ57qaY2haUN4wggM/MIICqKADAgECAgENMA0GCSqG SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBD YXBlMRIwEAYDVQQHEwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25z dWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZpY2F0aW9uIFNlcnZpY2VzIERpdmlz aW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgQ0ExKzAp BgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcN MDMwNzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTEl MCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UE AxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0EwgZ8wDQYJ KoZIhvcNAQEBBQADgY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUEcJ3f6f+j Huy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJjWiyJFXCO3cnwK4Vaqj9xVsuv PAsH5/EfkTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenprufZdHFKlSFD0gE f6e20TxhBEAeZBlyYLf7AgMBAAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIB ADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3JsLnRoYXd0ZS5jb20vVGhh d3RlUGVyc29uYWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYDVR0R BCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3 DQEBBQUAA4GBAEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0whuPg2H6ot nzYvwPQcUCCTcDz9reFhYsPZOhl+hLGZGwDFGguCdJ4lUJRix9sncVcljd2p nDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC3CEZNd4ksdMdRv9d X2VPMYIDEDCCAwwCAQEwdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBl cnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0ECEFT8y6jYgKvbR4T8stEWA9ww CQYFKw4DAhoFAKCCAW8wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkq hkiG9w0BCQUxDxcNMDcxMDA5MDQzMDA5WjAjBgkqhkiG9w0BCQQxFgQUo5E3 2JMST+4anTMZgF1Cn/qIUaowgYUGCSsGAQQBgjcQBDF4MHYwYjELMAkGA1UE BhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENB AhBU/Muo2ICr20eE/LLRFgPcMIGHBgsqhkiG9w0BCRACCzF4oHYwYjELMAkG A1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0 ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5n IENBAhBU/Muo2ICr20eE/LLRFgPcMA0GCSqGSIb3DQEBAQUABIIBABqvY7AC pqmbs3z26K9Qz8nudGACsVa13Tq35SZyvJ2lBf09zz44lPHs5PeOpXCf8cRx yl9KWSNR87LYHGy3slI2st82vSZPjw9O+bo6BHuG0Tc8ZJDQ8Umvoec7CEHy OwRchtGViahCl83pWc036GqPejTZ6y4unvktSRBSh+cze6U+x+rot1wmGbDN 17yYRMiUsjOP9mEbr2sL7KwMastsBgjUzZgFz8AQPJ57xZpYd049jmw6JD/u /O4OgyKUizlq8iMAXu3hXGtB7xSs6/7AFnkTZP+AHEbSsJh+ajrEFzN8RpYx JGutlAltiXBMu6V4LHLTcJz9z4tgX7DCi4sAAAAAAAA= --Apple-Mail-1-996128202--