From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by sourceware.org (Postfix) with ESMTPS id 728BC3858039 for ; Wed, 28 Jul 2021 15:29:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 728BC3858039 Received: by mail-qk1-x736.google.com with SMTP id 184so2602379qkh.1 for ; Wed, 28 Jul 2021 08:29:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eE2r4E0H1ZY4uufVbbdNms6/FbzzFRK0QXLTORwwhDs=; b=HGoNeCZAGQvUMgme01PWezMQHR/LUif+I3D5kX2qEH2OQm1o9eDG8Bbhd63I4LQdVX /6wMXoQFQSjrDKCEvhmbqOMN+n2O3/FaQyfwCpd6L/JMK2dWGunkGsf1vKcndJuoOFC9 FjJ4JjyD20cXdvawAtT7c8wNXhYYlYlPggpNMaEfSAlx0HbXx5cnsMQBlMEASB6KfSiY aoJoNeOWtyr1QTvNRRqd/jne4prxj6BkKDUiU1Mjw1hd8dbs5N3dzYMqqRW6r0LFUawB kZPfPS0Zt3N77gQDrcnUGAo+J4mJ4DFO5c3k9fT58iNCFqED7dZUebyzt/iKYiUdTtNW NcDQ== X-Gm-Message-State: AOAM5307unWoSSlzLpyWaXMJmBoKjT73Y5TdclnqHvfRyAI9mIRnX3gO R+IxhbBjUmZ5jilnyal+eYQ= X-Google-Smtp-Source: ABdhPJylMb+gb95dPj2i4vm/3B+jJgtS1cjxvZqtnZWDQcxD9NCOvii4EVvrd1ToZJd3Zg6b9hOZ3Q== X-Received: by 2002:a05:620a:99b:: with SMTP id x27mr232177qkx.138.1627486180140; Wed, 28 Jul 2021 08:29:40 -0700 (PDT) Received: from [192.168.0.41] (75-166-102-22.hlrn.qwest.net. [75.166.102.22]) by smtp.gmail.com with ESMTPSA id f3sm73540qti.65.2021.07.28.08.29.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 08:29:39 -0700 (PDT) Subject: Re: [PATCH 2/2] Backwards jump threader rewrite with ranger. To: Aldy Hernandez , Jeff Law , GCC patches Cc: Martin Sebor References: <20210628162147.631850-1-aldyh@redhat.com> <20210628162147.631850-3-aldyh@redhat.com> From: Martin Sebor Message-ID: <05a93863-8ff9-7766-0659-2bd953b2e489@gmail.com> Date: Wed, 28 Jul 2021 09:29:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 15:29:41 -0000 On 7/28/21 8:51 AM, Aldy Hernandez via Gcc-patches wrote: > > > On 7/28/21 4:32 PM, Jeff Law wrote: ... >>>> diff --git a/gcc/Makefile.in b/gcc/Makefile.in >>>> index 863f1256811..0e205a41ac3 100644 >>>> --- a/gcc/Makefile.in >>>> +++ b/gcc/Makefile.in >>>> @@ -223,6 +223,11 @@ gimple-match.o-warn = -Wno-unused >>>>   generic-match.o-warn = -Wno-unused >>>>   dfp.o-warn = -Wno-strict-aliasing >>>> +# maybe_emit_free_warning() is picking up the inlined location for the >>>> +# warning, not the source of the original va_heap::release() function >>>> +# which has a pragma disabling this warning. >>>> +tree-ssa-loop-im.o-warn = -Wno-free-nonheap-object >> I think some of Martin's work may help here, but I'm not sure if it's >> all gone in yet.  It might be worth syncing with him on the state of >> the improvements to how inlining and warnings interact.  If his work >> does fix the problem here, this hunk can be removed as a distinct >> follow-up. > > Yes.  He definitely has some patches in this space that were likely to > fix this.  I will re-test without this hunk, and remove it if it's fixed. I think I tested your patch on top of mine while it was still in review and confirmed that the workaround isn't necessary anymore. But if something's changed/regressed since then please let me know. Martin