From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id 6163E3861834 for ; Wed, 20 Dec 2023 17:41:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6163E3861834 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6163E3861834 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703094089; cv=none; b=lfor6cFeiExff5prWj/8AGuIqvTp/NQghS7pyBlFQM8ogA9bxkrgSpLwTn/pZc1c7OykEQ1I8bbRDHZpGP3JGd2mI+vj85A0uT3nZBvvQkBnajRnbj98joECdY+V4Iq20v4zHrDGUnX+S5lxYOc+s21SBRcdTpKcBixtWnDFV/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703094089; c=relaxed/simple; bh=wYcM1TMAtPkBHlZgis6A6kpVnE8fsZn7XZWd8IxR5XI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sJezex+NqmkiH/vIsHh/dj47Hr9oE8PykXgHb1NI6/TvgSWUjN62PedA7hUqRe7TICF4N21q6CcDeY4huRWIu7wDQnC3j9dX5/uvT5MJIMtbmQhSPo18/j66I+mPcl/dpbnqncj8PGgr3v3ktbHnqbD35L1+UJ0hdX64aJY2ZX8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-7ba7c845e1aso18739239f.2 for ; Wed, 20 Dec 2023 09:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703094087; x=1703698887; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NdAabI2vGI773KtI4uTZAE60YTr8/hEfnmO68A5SZjA=; b=AK20Sde0V/n25K7GrXXN/uJgrWYGwnOymzYXv8D4e4JPHepMqmdPSQSk7yGo2LmpAI HMCvwLS2IZPF/qcXypTlaCQicUJKFj5yF7/OuiPeYhO4V9fC/e31MhyPrD5HlkZMHsxZ 6phTtXpf6+sk6us58pa0BhcF7cqUtR0AnwAyNkrKfun/TfCEFAHBEOZGxIXMFiaRmwV+ H/U9R736xTK4p+KzV7xAHYJiKLLme1B4MJ8vu7jmWnJtg+3F5rJe3rT/TwoVIY9qkWrK Phicp2dozhUjn/TLQ4pMLf7dUZoBi9VMrltXtKr4yED8MQhKIP6qeY2o2a+k4r7+jpOV Iibw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703094087; x=1703698887; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NdAabI2vGI773KtI4uTZAE60YTr8/hEfnmO68A5SZjA=; b=KpaTOBEWQelTUXvsUEq+2XOP3k76Omw6OvVozE++RokmTTHK8P5886ixvi3rzrNFvi YJxUw47QBjzcXMYU0s7xDrq6tW1i4Ivb/Ib03awvN2oFpEAEbXXJsDi9TpGZuF0nhUuL zaXdyCthQUBBl4SF4xPILv3SSZi3kLCyJtVRzAI0IP++izE5xbaJagDlAmpMZ20aQZ3X b8qivTdi7eeSV4yky9vafopsF2DX13xjBHe+8EIahE9su9reNuaS56SK62J1xO1EVgrY RHm2A9AwVorAxkvkScFzwdO8G3S+WI20FLpdaeIe+TafBB4cy7HZXG8HiQHYGNcdCN+D SLgQ== X-Gm-Message-State: AOJu0YwH7wnQISHlLu5AHVejyDht2fAQ1zrJp6BTNr7I72AAM4KO9evO n0a0NmXHGV1NRPOsBOQv+B0= X-Google-Smtp-Source: AGHT+IHkpSruUcVcj7hFzC3J/09WAoemFaxvI3LEHqBWZofj0iW6AlL3yXUL2Ee4/EfnOB0jE02BgQ== X-Received: by 2002:a6b:e008:0:b0:7b7:160e:6f5 with SMTP id z8-20020a6be008000000b007b7160e06f5mr23001814iog.40.1703094087669; Wed, 20 Dec 2023 09:41:27 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id u9-20020a02b1c9000000b004665c938c62sm11194jah.120.2023.12.20.09.41.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 09:41:27 -0800 (PST) Message-ID: <05b4b8e8-feb1-407f-8aad-5424905d1fd2@gmail.com> Date: Wed, 20 Dec 2023 10:41:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Fix bug of VSETVL fusion Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, kito.cheng@sifive.com, rdapp.gcc@gmail.com References: <20231220065011.2696544-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20231220065011.2696544-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/19/23 23:50, Juzhe-Zhong wrote: > This patch fixes bugs in the fusion of this following case: > > li a5,-1 > vmv.s.x v0,a5 -> demand any non-zero AVL > vsetvli a5, ... > > Incorrect fusion after VSETVL PASS: > > li a5,-1 > vsetvli a5... > vmv.s.x v0, a5 --> a5 is modified as incorrect value. > > We disallow this incorrect fusion above. > > Full coverage testing of RV64 and RV32 no regression. > > PR target/113087 > > gcc/ChangeLog: > > * config/riscv/riscv-vsetvl.cc: Disallow fusion when VL modification pollutes non AVL use. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/autovec/pr113087-1.c: New test. OK. jeff