From: "Martin Liška" <mliska@suse.cz>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: gcc-patches@gcc.gnu.org, wschmidt@linux.ibm.com
Subject: Re: [PATCH] rs6000: Remove unnecessary option manipulation.
Date: Thu, 4 Nov 2021 11:08:32 +0100 [thread overview]
Message-ID: <05c992e3-d14b-a71b-954f-d6890d9ea9dc@suse.cz> (raw)
In-Reply-To: <060bea48-11b4-6c5e-7ac0-8e90d4689d9d@suse.cz>
@Segher: PING
On 10/19/21 16:43, Martin Liška wrote:
> On 10/19/21 16:23, Segher Boessenkool wrote:
>> On Fri, Oct 15, 2021 at 05:24:32PM +0200, Martin Liška wrote:
>>> On 10/14/21 17:10, Bill Schmidt via Gcc-patches wrote:
>>>> Looks like you got your parentheses wrong here.
>>>
>>> Whoops, thanks for the heads up.
>>>
>>> I'm testing this fixed version.
>>
>> Please start a new thread for every new patch (series). I missed this
>> one like this, instead I reviewed the older one.
>
> Is it really best practice. My impression is that patch review (iterating over
> a patch) happens in the same thread (in most cases). It's caused by discussion
> in between sender reviewers.
>
>>
>> [-- Attachment #2: 0001-rs6000-Remove-unnecessary-option-manipulation.patch --]
>> [-- Type: text/x-patch, Encoding: base64, Size: 2.6K --]
>
> Meh :) If I need a reply to somebody's questions, I always attach patch as an attachment.
> And I can't likely influence how Thunderbird is going to mark it.
>
>>
>> Don't encode as non-text. Don't use x-anything if you can help it, it
>> is meaningless in email.
>>
>> Use git send-email, it makes everything work :-)
>
> I know.
>
> Anyway, sending updated version of the patch.
>
> Cheers,
> Martin
>
>>
>>
>> Segher
>>
next prev parent reply other threads:[~2021-11-04 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 7:49 Martin Liška
2021-10-14 15:10 ` Bill Schmidt
2021-10-15 15:24 ` Martin Liška
2021-10-19 8:53 ` Martin Liška
2021-10-19 13:07 ` Bill Schmidt
2021-10-19 14:23 ` Segher Boessenkool
2021-10-19 14:43 ` Martin Liška
2021-11-04 10:08 ` Martin Liška [this message]
2021-11-04 11:38 ` Segher Boessenkool
2021-10-19 14:11 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c992e3-d14b-a71b-954f-d6890d9ea9dc@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).