From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 3F5663858C3A for ; Thu, 4 Nov 2021 10:08:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F5663858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 34255218B0; Thu, 4 Nov 2021 10:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1636020513; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/KRECbMUQTihRkNZRfjU+Sm+RlaMzjCGdPQnpY/hphA=; b=Q/HcXGNm/Geu5Y5SickLd1BqIFjowOj59waynRN/vMBNy2YRgLFMw9L1J/y0VukyOath8y aamJ33b0XerU6A7wkBHPGV1wl+a5msEeKy1MmW8Owdbvy5NlojCXrABWousptzhhHiokK3 YbxYtCGQl6K89Z/7wYXb3613CtUiiPA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1636020513; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/KRECbMUQTihRkNZRfjU+Sm+RlaMzjCGdPQnpY/hphA=; b=TibIM/6Cng0nxsajlEz00Yd5c7yt3q5s1nlP1c+QNFOLzdtnkMiz/BXwLNqsfO/+yDHIy/ 3UyOiW+Y2Mex7sDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C57913BD4; Thu, 4 Nov 2021 10:08:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pR7JBSGxg2GqNQAAMHmgww (envelope-from ); Thu, 04 Nov 2021 10:08:33 +0000 Message-ID: <05c992e3-d14b-a71b-954f-d6890d9ea9dc@suse.cz> Date: Thu, 4 Nov 2021 11:08:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] rs6000: Remove unnecessary option manipulation. Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, wschmidt@linux.ibm.com References: <2f57b5b5-3894-29b4-0e20-725bf273b496@suse.cz> <2715ef21-5d01-79bf-13c2-4b05a358cd41@linux.ibm.com> <20211019142342.GP614@gate.crashing.org> <060bea48-11b4-6c5e-7ac0-8e90d4689d9d@suse.cz> In-Reply-To: <060bea48-11b4-6c5e-7ac0-8e90d4689d9d@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 10:08:35 -0000 @Segher: PING On 10/19/21 16:43, Martin Liška wrote: > On 10/19/21 16:23, Segher Boessenkool wrote: >> On Fri, Oct 15, 2021 at 05:24:32PM +0200, Martin Liška wrote: >>> On 10/14/21 17:10, Bill Schmidt via Gcc-patches wrote: >>>> Looks like you got your parentheses wrong here. >>> >>> Whoops, thanks for the heads up. >>> >>> I'm testing this fixed version. >> >> Please start a new thread for every new patch (series).  I missed this >> one like this, instead I reviewed the older one. > > Is it really best practice. My impression is that patch review (iterating over > a patch) happens in the same thread (in most cases). It's caused by discussion > in between sender reviewers. > >> >> [-- Attachment #2: 0001-rs6000-Remove-unnecessary-option-manipulation.patch --] >> [-- Type: text/x-patch, Encoding: base64, Size: 2.6K --] > > Meh :) If I need a reply to somebody's questions, I always attach patch as an attachment. > And I can't likely influence how Thunderbird is going to mark it. > >> >> Don't encode as non-text.  Don't use x-anything if you can help it, it >> is meaningless in email. >> >> Use git send-email, it makes everything work :-) > > I know. > > Anyway, sending updated version of the patch. > > Cheers, > Martin > >> >> >> Segher >>