From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 29D9E3858C98 for ; Mon, 20 Nov 2023 07:02:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29D9E3858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 29D9E3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700463755; cv=none; b=U5Jg08iJ8nwdEP0jgZSGqRnjJPs3o/wzt8Y+usPtW2w7LCVRCH4PcVPwBqPPiUDFcJU8w4RY2rzEZEke81YcfrB60D3d9Xn5uoUNs2l6vDc5c4wcwaFIQb5u/ucM3gS4z90xC5spT+GZKRrUh1avmacmF5gsaEIxbmlEUVow/vg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700463755; c=relaxed/simple; bh=zUHAVlNNZPW87kVG5kLk+OD0bApZyUM9Dx1DZzlYXE4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=taVovyPiBBg9T+68AkszuctRtkM0GwqOszRL64/xMb+/b+rIXDvtDag+JJNpeIyhhQhgW27/183IIFlj0qPqtTBHMXWsQbc/KMYL3P8HFECHbiM3711pD7zlQk9FCbg85DNnaX9hh8Iz7PpEHrnyPV2NoB+qmr3Dl6WAKY/ZSXo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3b6ccaf0516so2532169b6e.0 for ; Sun, 19 Nov 2023 23:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700463744; x=1701068544; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ysBFetNPrj0kgkUDT4CZq7vNmI9RVTjt5hI6tZ+hFMM=; b=Qh5T9ixOsH6mlK1YkBHTYm9lN5mTHP9EoCs30KdDHqqUFOXoHekS1jUR1SMisbEdh+ Qmlm7lc9kKqH8yVinQlqgTBex3TusfQtOlBo9mPE9ALdbBMyu2UQMqfO/crvWJO6X7XS FjYOlcTtBw1vRWsP5/WcqZybsk53RGW6H5b2ec/hJdzl8yv85lEYM2QgHTNLopg0IbET xEVtz8Z/95CFZG767EbjISz2qbc+wRwIplkspsEnB52J1+NHhdRCyh010Ky7mlROBlHK FwbpSTfhDsDjD1tttpZzcNRHkG1cg1fPsndI5UuerUyMsZCpxv6iO1GX4M6JsjuaCa6p XA8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700463744; x=1701068544; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ysBFetNPrj0kgkUDT4CZq7vNmI9RVTjt5hI6tZ+hFMM=; b=VIgKATYUFMU1r8hyvKcei8iGotyZFkMKEN3lN4gnbi6J+EKGLnbXza/JpxAXNLkm1m kmenBV5RrMnkb44RzUPxCeEo51t3fbT/Q2N9r2EGFUfzJ68C61rKajJ1y/ONGvw4U9gl j4SSELnlX/C8jwNIjNn2H/ajsDR4s6D7+++KO85cnSwgPrrADt7ZHj1t/0e0wQlAC1Jw DYAtUm8Kw3+38HpFet7GGepPMmfDO6OxsXO3QDuQHxqqNoAP6QRyTNEaa68sDJ4a9Mts kBtxCrEdgWQ4SN2pc9QaUSrj/DEBQwAT1dabSbW7PXfBbnqtln5pqeGwnrsdJ+7DnF+g d7aQ== X-Gm-Message-State: AOJu0Yz66+XrdKpG7DLtZNjfwiGpNzR9mMu/wJGMc1QCoEeo5S4LK3Sa Egylr0NB+cjMi/J6TnJHl/M= X-Google-Smtp-Source: AGHT+IGiLBKmEgYB0bMT11wIo3AUaeCEZjP3imWToMbubuC6srjEdxUhmM4UivE8y+Gjby4KjvyoZw== X-Received: by 2002:a05:6808:d1:b0:3b2:e4b7:2af2 with SMTP id t17-20020a05680800d100b003b2e4b72af2mr6124921oic.6.1700463744395; Sun, 19 Nov 2023 23:02:24 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id e2-20020a05683013c200b006d3127234d7sm1084396otq.8.2023.11.19.23.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 23:02:23 -0800 (PST) Message-ID: <05ed1869-1bcc-4605-8f6b-b1a17c2b674d@gmail.com> Date: Mon, 20 Nov 2023 00:02:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] [ifcvt] if convert x=c ? y op z : y by RISC-V Zicond like insns Content-Language: en-US To: Fei Gao , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, palmer@dabbelt.com References: <20231030072523.26818-1-gaofei@eswincomputing.com> <20231030072523.26818-4-gaofei@eswincomputing.com> From: Jeff Law In-Reply-To: <20231030072523.26818-4-gaofei@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/30/23 01:25, Fei Gao wrote: > > +static bool > +noce_cond_zero_binary_op_supported (enum rtx_code op) Function needs function comment. And again in your new tests, don't require explicit registers unless you know (due to use as function argument/return value) which register will be used. Using explicit registers increases the maintenance and is best avoided. jeff