From: Jeff Law <jeffreyalaw@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>, GCC patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Cleanup --params for backward threader.
Date: Thu, 14 Oct 2021 08:30:29 -0600 [thread overview]
Message-ID: <05fe5ebe-2836-30d8-d43e-cdbc28afbbb2@gmail.com> (raw)
In-Reply-To: <20211014142547.251144-1-aldyh@redhat.com>
On 10/14/2021 8:25 AM, Aldy Hernandez wrote:
> The new backward threader makes some of the --param knobs used to
> control it questionable at best or no longer applicable at worst.
>
> The fsm-maximum-phi-arguments param is unused and can be removed.
>
> The max-fsm-thread-length param is block based which is a bit redundant,
> since we already restrict paths based on instruction estimates.
>
> The max-fsm-thread-paths restricts the total number of threadable paths
> in a function. We probably don't need this. Besides, the forward
> threader has no such restriction.
>
> OK pending tests?
>
> gcc/ChangeLog:
>
> * doc/invoke.texi: Remove max-fsm-thread-length,
> max-fsm-thread-paths, and fsm-maximum-phi-arguments.
> * params.opt: Same.
> * tree-ssa-threadbackward.c (back_threader::back_threader): Remove
> argument.
> (back_threader_registry::back_threader_registry): Same.
> (back_threader_profitability::profitable_path_p): Remove
> param_max_fsm_thread-length.
> (back_threader_registry::register_path): Remove
> m_max_allowable_paths.
OK. I don't think any of those params were addressing pathological
cases and thread-length is really handled better by costing based on the
# statements.
jeff
next prev parent reply other threads:[~2021-10-14 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 14:25 Aldy Hernandez
2021-10-14 14:30 ` Jeff Law [this message]
2021-10-19 20:39 ` Jan-Benedict Glaw
2021-10-19 20:55 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05fe5ebe-2836-30d8-d43e-cdbc28afbbb2@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).