From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 26C233858004 for ; Thu, 14 Oct 2021 14:30:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26C233858004 Received: by mail-pg1-x529.google.com with SMTP id 133so5737710pgb.1 for ; Thu, 14 Oct 2021 07:30:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Q4WkDcI6W+X6UYVdU9Q84ci4YZpce1Frn0QqRB8LmHw=; b=r9brWfzmlKqaoC7NiL2YtA50RR3bVAXKnFYd35gmP9yAySAYIc6BWDY9dvYXqPvu4u 8jhma+iORQjoHqCxrfqVJ5UmDHw71Zm36dNIXVwWU7HDnBuIMHdes65Q7A7bAiRvqwOl At/omTeW6bknxd+VytgbuaAETIwnHmzke6xRCVGc8bGFUffMO6MqeCV0PE4NEa0JuH06 5TtsW1KUt5HIKJcwY8I75I1G1qsCIidGgtqGrkvpSnLnLMLZnrKODFy+yv+EussCQ8e8 sAc3jJRDomBZnSyeS0WOZmPo9g7NooB62jbyhsBzixts53Q4TnHeSSyZPb0YG02tlje2 bYQQ== X-Gm-Message-State: AOAM533jlc4cWUcH2cemxLTwRe4hrcI9OzMNwCLBAPXaFj1DCFfE6v18 Za0zVbtjmKqg52SW6uRiNgR1nVLhwJk= X-Google-Smtp-Source: ABdhPJzPlSSbrc0kPGL83VWpZX3DA8+mEDwjUk3p13bEGzFdkht9qHIzHBDouOyaYIq1BlLx9+mCLA== X-Received: by 2002:a63:f913:: with SMTP id h19mr4526295pgi.351.1634221830121; Thu, 14 Oct 2021 07:30:30 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id t28sm2775736pfq.158.2021.10.14.07.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 07:30:29 -0700 (PDT) Subject: Re: [PATCH] Cleanup --params for backward threader. To: Aldy Hernandez , GCC patches References: <20211014142547.251144-1-aldyh@redhat.com> From: Jeff Law Message-ID: <05fe5ebe-2836-30d8-d43e-cdbc28afbbb2@gmail.com> Date: Thu, 14 Oct 2021 08:30:29 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211014142547.251144-1-aldyh@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Oct 2021 14:30:32 -0000 On 10/14/2021 8:25 AM, Aldy Hernandez wrote: > The new backward threader makes some of the --param knobs used to > control it questionable at best or no longer applicable at worst. > > The fsm-maximum-phi-arguments param is unused and can be removed. > > The max-fsm-thread-length param is block based which is a bit redundant, > since we already restrict paths based on instruction estimates. > > The max-fsm-thread-paths restricts the total number of threadable paths > in a function. We probably don't need this. Besides, the forward > threader has no such restriction. > > OK pending tests? > > gcc/ChangeLog: > > * doc/invoke.texi: Remove max-fsm-thread-length, > max-fsm-thread-paths, and fsm-maximum-phi-arguments. > * params.opt: Same. > * tree-ssa-threadbackward.c (back_threader::back_threader): Remove > argument. > (back_threader_registry::back_threader_registry): Same. > (back_threader_profitability::profitable_path_p): Remove > param_max_fsm_thread-length. > (back_threader_registry::register_path): Remove > m_max_allowable_paths. OK.  I don't think any of those params were addressing pathological cases and thread-length is really handled better by costing based on the # statements. jeff