From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Xp6E=37=mentor.com=Andrew_Stubbs@sourceware.org>
Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180])
	by sourceware.org (Postfix) with ESMTPS id 737713858D32
	for <gcc-patches@gcc.gnu.org>; Thu,  1 Dec 2022 12:45:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 737713858D32
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="5.96,209,1665475200"; 
   d="scan'208";a="88148730"
Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167])
  by esa3.mentor.iphmx.com with ESMTP; 01 Dec 2022 04:45:51 -0800
IronPort-SDR: ZokJwyKJziztL0pMAjGO3B2UcofwgRBnA7RwWnjw3t1XsyjFTHTpZH5nF7PAUIt5AefHGDBWSt
 me+caeT47xmHMs5jCBKPdc1SYk186uiUpSY+wfV1x44t3+FzcBn4tibjNF7Hq2ZWG0uWpJI529
 fQuzUsl8FwQBtKX9xKkQSJHENHttkJBXqa0QnK4E9lgCPxm6l8CfIVHF8igYfiHr6Z8eU2mdAY
 xNJrEtzxiGmCR0AR595FHX1zrMHuE24rauZZgQDY8Sb9ZEtTQZ+W5pGgaD4iKPLiWV0cq1c5+/
 7ps=
Message-ID: <0600a1e2-d877-6522-15a9-0e5d0219a76b@codesourcery.com>
Date: Thu, 1 Dec 2022 12:45:45 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH][OG12] amdgcn: Support AMD-specific 'isa' and 'arch'
 traits in OpenMP context selectors
To: Paul-Antoine Arras <pa@codesourcery.com>, Kwok Cheung Yeung
	<kcyeung77@gmail.com>
CC: gcc-patches <gcc-patches@gcc.gnu.org>
References: <e929111e-d5f2-8ed3-c3ec-f1280615d8fc@codesourcery.com>
 <202ee18b-90c8-830b-82a5-b705a9ec5c73@gmail.com>
 <82a884ed-ea1d-5116-fedf-42de6e22e730@codesourcery.com>
Content-Language: en-GB
From: Andrew Stubbs <ams@codesourcery.com>
In-Reply-To: <82a884ed-ea1d-5116-fedf-42de6e22e730@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To
 svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11)
X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On 01/12/2022 11:10, Paul-Antoine Arras wrote:
> +      if (TARGET_FIJI)                                                         \
> +	builtin_define ("__FIJI__");                                           \
> +      else if (TARGET_VEGA10)                                                  \
> +	builtin_define ("__VEGA10__");                                         \
> +      else if (TARGET_VEGA20)                                                  \
> +	builtin_define ("__VEGA20__");                                         \
> +      else if (TARGET_GFX908)                                                  \
> +	builtin_define ("__GFX908__");                                         \
> +      else if (TARGET_GFX90a)                                                  \
> +	builtin_define ("__GFX90a__");                                         \
> +  } while (0)
>  

I don't think it makes sense to say __VEGA10__ when the user asked for 
-march=gfx900.

This whole naming thing is a bit of a mess already, so I think we'd do 
better to either keep the same names throughout or match what LLVM does 
(since it got to these first).

Please use "__gfx900__" etc. (lower case).

I'm half tempted to do a global search and replace on the internal 
names, but since they're not externally visible that would probably just 
be making merge conflicts for the sake of it.

Thanks

Andrew

P.S. If you want to split the patch into the GCN bits and the bits that 
depend on metadirectives then we can apply the first part to mainline 
right away.