From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 3EC613858D39 for ; Tue, 19 Oct 2021 14:43:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3EC613858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1FB762197F; Tue, 19 Oct 2021 14:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634654621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lclBtXaYmRTz3I7tYl1R3QwlzwiEG0mePRdPrhMFlcA=; b=AJtu54JuiiiNVpSeAn0YjDurtiTvC3nEbFDXwPBclugOsq3jZ3QZENPoxF6tqNBgaw6asp GR01wajLO3DNkiiaC8zUvyaargInFv9xGI8LJYFAFgic30DA9waw0IYm+GpparBhcLLRk2 nsgh9/w0BVZMoeSsMFdI463GQ+UdxZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634654621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lclBtXaYmRTz3I7tYl1R3QwlzwiEG0mePRdPrhMFlcA=; b=Y4ge2TX+wrS/Qhz9pqfIE14WIbIFp59cSecogzVWo1XWkLDAgIMNTBjBIYl4tmMDx+qwjS 4BAIMOIUvTeSITAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0721813E4D; Tue, 19 Oct 2021 14:43:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mxVyO5zZbmFiWAAAMHmgww (envelope-from ); Tue, 19 Oct 2021 14:43:40 +0000 Content-Type: multipart/mixed; boundary="------------IKzZAgbG9GxcepAf02M7wnbV" Message-ID: <060bea48-11b4-6c5e-7ac0-8e90d4689d9d@suse.cz> Date: Tue, 19 Oct 2021 16:43:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] rs6000: Remove unnecessary option manipulation. Content-Language: en-US To: Segher Boessenkool Cc: wschmidt@linux.ibm.com, gcc-patches@gcc.gnu.org References: <2f57b5b5-3894-29b4-0e20-725bf273b496@suse.cz> <2715ef21-5d01-79bf-13c2-4b05a358cd41@linux.ibm.com> <20211019142342.GP614@gate.crashing.org> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20211019142342.GP614@gate.crashing.org> X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 14:43:43 -0000 This is a multi-part message in MIME format. --------------IKzZAgbG9GxcepAf02M7wnbV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/19/21 16:23, Segher Boessenkool wrote: > On Fri, Oct 15, 2021 at 05:24:32PM +0200, Martin Liška wrote: >> On 10/14/21 17:10, Bill Schmidt via Gcc-patches wrote: >>> Looks like you got your parentheses wrong here. >> >> Whoops, thanks for the heads up. >> >> I'm testing this fixed version. > > Please start a new thread for every new patch (series). I missed this > one like this, instead I reviewed the older one. Is it really best practice. My impression is that patch review (iterating over a patch) happens in the same thread (in most cases). It's caused by discussion in between sender reviewers. > > [-- Attachment #2: 0001-rs6000-Remove-unnecessary-option-manipulation.patch --] > [-- Type: text/x-patch, Encoding: base64, Size: 2.6K --] Meh :) If I need a reply to somebody's questions, I always attach patch as an attachment. And I can't likely influence how Thunderbird is going to mark it. > > Don't encode as non-text. Don't use x-anything if you can help it, it > is meaningless in email. > > Use git send-email, it makes everything work :-) I know. Anyway, sending updated version of the patch. Cheers, Martin > > > Segher > --------------IKzZAgbG9GxcepAf02M7wnbV Content-Type: text/x-patch; charset=UTF-8; name="0001-rs6000-Remove-unnecessary-option-manipulation.patch" Content-Disposition: attachment; filename="0001-rs6000-Remove-unnecessary-option-manipulation.patch" Content-Transfer-Encoding: base64 RnJvbSBkMzJkOTQ0NWQ4ZWM4NjhhYmM5NjVmMTY3ZmZmYTEwYWIxOTQxN2U1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBXZWQsIDEzIE9jdCAyMDIxIDE0OjIwOjMzICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cnM2MDAwOiBSZW1vdmUgdW5uZWNlc3Nhcnkgb3B0aW9uIG1hbmlwdWxhdGlvbi4KCmdjYy9D aGFuZ2VMb2c6CgoJKiBjb25maWcvcnM2MDAwL3JzNjAwMC5jIChyczYwMDBfb3ZlcnJpZGVf b3B0aW9uc19hZnRlcl9jaGFuZ2UpOgoJRG8gbm90IHNldCBmbGFnX3JlbmFtZV9yZWdpc3Rl cnMsIGl0J3MgYWxyZWFkeSBlbmFibGVkIHdpdGgKCUVuYWJsZWRCeShmdW5yb2xsLWxvb3Bz KS4KCVVzZSBFbmFibGVkQnkgZm9yIHVucm9sbF9vbmx5X3NtYWxsX2xvb3BzLgoJKiBjb25m aWcvcnM2MDAwL3JzNjAwMC5vcHQ6IFVzZSBFbmFibGVkQnkgZm9yCgl1bnJvbGxfb25seV9z bWFsbF9sb29wcy4KLS0tCiBnY2MvY29uZmlnL3JzNjAwMC9yczYwMDAuYyAgIHwgNyArLS0t LS0tCiBnY2MvY29uZmlnL3JzNjAwMC9yczYwMDAub3B0IHwgMiArLQogMiBmaWxlcyBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ2Nj L2NvbmZpZy9yczYwMDAvcnM2MDAwLmMgYi9nY2MvY29uZmlnL3JzNjAwMC9yczYwMDAuYwpp bmRleCAwMWE5NTU5MWE1ZC4uYjlkZGRjZDBhYTEgMTAwNjQ0Ci0tLSBhL2djYy9jb25maWcv cnM2MDAwL3JzNjAwMC5jCisrKyBiL2djYy9jb25maWcvcnM2MDAwL3JzNjAwMC5jCkBAIC0z NDcyLDEzICszNDcyLDggQEAgcnM2MDAwX292ZXJyaWRlX29wdGlvbnNfYWZ0ZXJfY2hhbmdl ICh2b2lkKQogICAvKiBFeHBsaWNpdCAtZnVucm9sbC1sb29wcyB0dXJucyAtbXVucm9sbC1v bmx5LXNtYWxsLWxvb3BzIG9mZiwgYW5kCiAgICAgIHR1cm5zIC1mcmVuYW1lLXJlZ2lzdGVy cyBvbi4gICovCiAgIGlmICgoT1BUSU9OX1NFVF9QIChmbGFnX3Vucm9sbF9sb29wcykgJiYg ZmxhZ191bnJvbGxfbG9vcHMpCi0gICAgICAgfHwgKE9QVElPTl9TRVRfUCAoZmxhZ191bnJv bGxfYWxsX2xvb3BzKQotCSAgICYmIGZsYWdfdW5yb2xsX2FsbF9sb29wcykpCisgICAgICAg fHwgKE9QVElPTl9TRVRfUCAoZmxhZ191bnJvbGxfYWxsX2xvb3BzKSAmJiBmbGFnX3Vucm9s bF9hbGxfbG9vcHMpKQogICAgIHsKLSAgICAgIGlmICghT1BUSU9OX1NFVF9QICh1bnJvbGxf b25seV9zbWFsbF9sb29wcykpCi0JdW5yb2xsX29ubHlfc21hbGxfbG9vcHMgPSAwOwotICAg ICAgaWYgKCFPUFRJT05fU0VUX1AgKGZsYWdfcmVuYW1lX3JlZ2lzdGVycykpCi0JZmxhZ19y ZW5hbWVfcmVnaXN0ZXJzID0gMTsKICAgICAgIGlmICghT1BUSU9OX1NFVF9QIChmbGFnX2N1 bnJvbGxfZ3Jvd19zaXplKSkKIAlmbGFnX2N1bnJvbGxfZ3Jvd19zaXplID0gMTsKICAgICB9 CmRpZmYgLS1naXQgYS9nY2MvY29uZmlnL3JzNjAwMC9yczYwMDAub3B0IGIvZ2NjL2NvbmZp Zy9yczYwMDAvcnM2MDAwLm9wdAppbmRleCA5ZDc4NzhmMTQ0YS4uZmFlYjc0MjNjYTcgMTAw NjQ0Ci0tLSBhL2djYy9jb25maWcvcnM2MDAwL3JzNjAwMC5vcHQKKysrIGIvZ2NjL2NvbmZp Zy9yczYwMDAvcnM2MDAwLm9wdApAQCAtNTQ2LDcgKzU0Niw3IEBAIFRhcmdldCBVbmRvY3Vt ZW50ZWQgVmFyKHJzNjAwMF9vcHRpbWl6ZV9zd2FwcykgSW5pdCgxKSBTYXZlCiBBbmFseXpl IGFuZCByZW1vdmUgZG91Ymxld29yZCBzd2FwcyBmcm9tIFZTWCBjb21wdXRhdGlvbnMuCiAK IG11bnJvbGwtb25seS1zbWFsbC1sb29wcwotVGFyZ2V0IFVuZG9jdW1lbnRlZCBWYXIodW5y b2xsX29ubHlfc21hbGxfbG9vcHMpIEluaXQoMCkgU2F2ZQorVGFyZ2V0IFVuZG9jdW1lbnRl ZCBWYXIodW5yb2xsX29ubHlfc21hbGxfbG9vcHMpIEluaXQoMCkgU2F2ZSBFbmFibGVkQnko ZnVucm9sbC1sb29wcykKIDsgVXNlIGNvbnNlcnZhdGl2ZSBzbWFsbCBsb29wIHVucm9sbGlu Zy4KIAogbXBvd2VyOS1taXNjCi0tIAoyLjMzLjEKCg== --------------IKzZAgbG9GxcepAf02M7wnbV--