From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56316 invoked by alias); 26 Jun 2017 16:44:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 56118 invoked by uid 89); 26 Jun 2017 16:44:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1784 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Jun 2017 16:44:19 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 89BF98124F; Mon, 26 Jun 2017 16:44:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 89BF98124F Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 89BF98124F Received: from localhost.localdomain (ovpn-117-103.phx2.redhat.com [10.3.117.103]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D7707E4D2; Mon, 26 Jun 2017 16:44:17 +0000 (UTC) Subject: Re: common grounds for VxWorks 7 support To: Olivier Hainque , GCC Patches , Nathan Sidwell Cc: Jerome Lambourg , Douglas B Rupp References: From: Jeff Law Message-ID: <0627e79e-4b28-ab68-60a6-4641553f3e03@redhat.com> Date: Mon, 26 Jun 2017 16:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01945.txt.bz2 On 06/26/2017 09:38 AM, Olivier Hainque wrote: > Hello, > > This patch introduces common grounds for VxWorks 7 support. > > The main device is the introduction of a TARGET_VXWORKS7 macro which we > leverage throughout the various vxworks.h / vxworks.c files, common or cpu > specific. > > We have done several CPU specific ports already, and this scheme works pretty > well. > > There's quite a bit of common material between Vx7 and the previous versions. > > For the distinctions we need to make, the use of preprocessing doesn't impair > readability IMO, on the contrary, while the usual alternative with extra target > files rapidly becomes subtle to handle right (getting the proper inclusion > ordering while preventing code duplication is not always easy and may make > maintenance harder or more error-prone). > > Nathan does this work for you ? > > If OK on principle, I'm not sure who is to approve the tiny config.gcc part. > > Thanks in advance for your feedback, > > With Kind Regards, > > Olivier > > 2017-06-26 Jerome Lambourg > Olivier Hainque > > * config.gcc (tm_defines for VxWorks): Define TARGET_VXWORKS7 for > all vxworks7 targets. > * config/vxworks.h (TARGET_VXWORKS7): If not defined, define to 0. > (VXWORKS_ADDITIONAL_CPP_SPEC): Alternative definition for VXWORKS7. > (VXWORKS_LIBS_RTP, VXWORKS_LIBS_RTP_DIR): New macros, allowing > variations for VX6/VX7 and 32/64bits later on in ... > (VXWORKS_LIB_SPEC): Leverage new macros. > (VXWORKS_OS_CPP_BUILTINS): Define _VSB_CONFIG_FILE for VXWORKS7, > as well as _ALLOW_KEYWORD_MACROS when "inline" is not a keyword. > I'd think the tiny config.gcc bits would fall under the VxWorks umbrella and you can self-approve. jeff