From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 0BB6C3858D1E for ; Wed, 17 May 2023 06:24:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BB6C3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34H69w2h018848; Wed, 17 May 2023 06:24:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=0GSPxZHXa/yjAcB7GTZhBKyDN8/gdaSq0C3uYhJ0KCk=; b=WUeP4dcStf0kHGEyO460fYEkVEgTE2thgdNkR6FlXKDZy4xs8fglUOzMVzXavmyLDJNm bIo4sJNVIfg+zMy1O+l8k+3kYlrE5iLxjawFnHHCSMO5FuYIp2QX7t5TUDccLecBUp3m OVhngtzwNtTtBRL/ACN2ldD217g3XkV2Lnqe576TI5lzXTvazIO9PHgOYrfWc3q2hFou fQgdIUn3LWnzot1L5VRs8A8jRJEVuHAkTK+YQhCbyXHoYM1jERHh9AzFgAm9jiQatQqJ gScUcyK7Sm9hkn9Js0spWPohVUJNLB7spJILpZr6EJlT3CJusdRtJEOwB7GmP8qjj+eV vg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qmrsqh5kg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 06:24:30 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 34H6J9Pc020037; Wed, 17 May 2023 06:24:30 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qmrsqh5k0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 06:24:29 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34H3w3BT008650; Wed, 17 May 2023 06:24:28 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma01fra.de.ibm.com (PPS) with ESMTPS id 3qj264snsx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 06:24:28 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34H6OOmF16777798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 May 2023 06:24:24 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 564242004B; Wed, 17 May 2023 06:24:24 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 07C0820043; Wed, 17 May 2023 06:24:21 +0000 (GMT) Received: from [9.177.81.160] (unknown [9.177.81.160]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 17 May 2023 06:24:20 +0000 (GMT) Message-ID: <063814db-ad94-727a-685e-0c7039d725a2@linux.ibm.com> Date: Wed, 17 May 2023 14:24:19 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: PING^1 [PATCH] libgcc: Use initarray section type for .init_stack Content-Language: en-US To: GCC Patches Cc: AlanM , Segher Boessenkool , David Edelsohn , Peter Bergner , Uros Bizjak , ian@airs.com, krebbel@linux.ibm.com References: <050edd6f-0ad9-fbad-a9e5-03ec7b937971@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <050edd6f-0ad9-fbad-a9e5-03ec7b937971@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 1RAuoyAIUjH7BQe20jaX5u5xt24TNqYb X-Proofpoint-ORIG-GUID: rbCyo38CamuXamB-LTuLITS1Dqm_Frpf Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-16_14,2023-05-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 spamscore=0 mlxscore=0 phishscore=0 impostorscore=0 clxscore=1011 priorityscore=1501 suspectscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305170051 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2023-March/614228.html BR, Kewen on 2023/3/20 14:33, Kewen.Lin via Gcc-patches wrote: > Hi, > > One of my workmates found there is a warning like: > > libgcc/config/rs6000/morestack.S:402: Warning: ignoring > incorrect section type for .init_array.00000 > > when compiling libgcc/config/rs6000/morestack.S. > > Since commit r13-6545 touched that file recently, which was > suspected to be responsible for this warning, I did some > investigation and found this is a warning staying for a long > time. For section .init_stack*, it's preferred to use > section type SHT_INIT_ARRAY. So this patch is use > "@init_array" to replace "@progbits". > > Although the warning is trivial, Segher suggested me to > post this to fix it, in order to avoid any possible > misunderstanding/confusion on the warning. > > As Alan confirmed, this doesn't require a premise check > on if the existing binutils supports "@init_array" or not, > "because if you want split-stack to work, you must link > with gold, any version of binutils that has gold has an > assembler that understands @init_array". (Thanks Alan!) > > Bootstrapped and regtested on x86_64-redhat-linux > and powerpc64{,le}-linux-gnu. > > Is it ok for trunk when next stage 1 comes? > > BR, > Kewen > ----- > libgcc/ChangeLog: > > * config/i386/morestack.S: Use @init_array rather than > @progbits for section type of section .init_array. > * config/rs6000/morestack.S: Likewise. > * config/s390/morestack.S: Likewise. > --- > libgcc/config/i386/morestack.S | 2 +- > libgcc/config/rs6000/morestack.S | 2 +- > libgcc/config/s390/morestack.S | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libgcc/config/i386/morestack.S b/libgcc/config/i386/morestack.S > index 7ae99b50cf5..c822b71e2dd 100644 > --- a/libgcc/config/i386/morestack.S > +++ b/libgcc/config/i386/morestack.S > @@ -850,7 +850,7 @@ __morestack_make_guard: > # This is ELF specific. > > #if HAVE_INITFINI_ARRAY_SUPPORT > - .section .init_array.00000,"aw",@progbits > + .section .init_array.00000,"aw",@init_array > #else > .section .ctors.65535,"aw",@progbits > #endif > diff --git a/libgcc/config/rs6000/morestack.S b/libgcc/config/rs6000/morestack.S > index f2fea6abb10..dd1e27cd454 100644 > --- a/libgcc/config/rs6000/morestack.S > +++ b/libgcc/config/rs6000/morestack.S > @@ -399,7 +399,7 @@ ENTRY0(__morestack_make_guard) > > # Make __stack_split_initialize a high priority constructor. > #if HAVE_INITFINI_ARRAY_SUPPORT > - .section .init_array.00000,"aw",@progbits > + .section .init_array.00000,"aw",@init_array > #else > .section .ctors.65535,"aw",@progbits > #endif > diff --git a/libgcc/config/s390/morestack.S b/libgcc/config/s390/morestack.S > index 09a49bb8851..f52e7a6510c 100644 > --- a/libgcc/config/s390/morestack.S > +++ b/libgcc/config/s390/morestack.S > @@ -597,7 +597,7 @@ __morestack_make_guard: > # Make __stack_split_initialize a high priority constructor. > > #if HAVE_INITFINI_ARRAY_SUPPORT > - .section .init_array.00000,"aw",@progbits > + .section .init_array.00000,"aw",@init_array > #else > .section .ctors.65535,"aw",@progbits > #endif > -- > 2.31.1