From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111957 invoked by alias); 3 Sep 2016 09:13:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 111893 invoked by uid 89); 3 Sep 2016 09:13:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:f839c74..bb0de4f, UD:substring-locations.c, sk:GCC_SUB, substring_loc X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 03 Sep 2016 09:13:31 +0000 Received: by mail-wm0-f68.google.com with SMTP id v143so5825528wmv.1 for ; Sat, 03 Sep 2016 02:13:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=eVEruMXnfZRx/X0Ywd7DxlDnQo+z/VQQWSHMWAGBxwQ=; b=Tf5fHPmQHMwO/EUr2/voMsDiH+m3srep7TnLi1yXa2wHvL1Pupb/5SbgtP29g238NT nH4EepJUJITtAkTsoxdyCPYFquwtfNTGxS5hMgoTc8amJ/wnLjZ33tvxo/8KHUmNNQ2E MKESl3YxwOnnQX4TQ/jZzrOPQ0gFOnu9wM8iO5P2C5WSunZhbu8Pfplgpgdw/YdVZ5EK w0zcahMPCQ5CwVSeftw1qR5/SRYZ2kVKgqhqUV2pQBlUwluEc8YXma+5OyBG5y1J5N9n 02hblGHge6o5UHEB4Tkw9mwuEqY5ywWmkETK9EFezx9wkBVV9Ck4QY+aznb0vH0RSsxB 3d5g== X-Gm-Message-State: AE9vXwMX4H7Zj5ji70rdI7oLPA2bb9UO5hi+kY09Lm6VlQCj7RYdRL2ATJldVvRiX6co0Q== X-Received: by 10.194.17.65 with SMTP id m1mr12745652wjd.131.1472894009552; Sat, 03 Sep 2016 02:13:29 -0700 (PDT) Received: from ?IPv6:2a02:c7d:2a2e:5500:d9bc:792b:b8f0:8f1f? ([2a02:c7d:2a2e:5500:d9bc:792b:b8f0:8f1f]) by smtp.googlemail.com with ESMTPSA id v137sm1989632wmf.3.2016.09.03.02.13.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Sep 2016 02:13:28 -0700 (PDT) Subject: Re: [PATCH] Move class substring_loc from c-family into gcc To: Martin Sebor , David Malcolm , GCC Patches References: <1472141352-10884-1-git-send-email-dmalcolm@redhat.com> <57CA035B.6080206@gmail.com> From: =?UTF-8?B?TWFudWVsIEzDs3Blei1JYsOhw7Fleg==?= Message-ID: <067a2cb4-5380-34be-2ec6-d501010a3fb7@gmail.com> Date: Sat, 03 Sep 2016 09:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57CA035B.6080206@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00140.txt.bz2 On 02/09/16 23:55, Martin Sebor wrote: >> diff --git a/gcc/substring-locations.h b/gcc/substring-locations.h >> index f839c74..bb0de4f 100644 >> --- a/gcc/substring-locations.h >> +++ b/gcc/substring-locations.h >> @@ -20,6 +20,73 @@ along with GCC; see the file COPYING3. If not see >> #ifndef GCC_SUBSTRING_LOCATIONS_H >> #define GCC_SUBSTRING_LOCATIONS_H >> >> +#include >> + Is this header file going to be used in the middle-end? If so, then it is suspicious that it includes cpplib.h. Otherwise, perhaps it should live in c-family/ I'm not complaining about substring-locations.c because libcpp is already linked with everything else even for other non-C languages, like Ada, but the above is leaking all cpplib.h into the rest of the compiler, which defeats the purpose of this in coretypes.h /* Provide forward struct declaration so that we don't have to include all of cpplib.h whenever a random prototype includes a pointer. Note that the cpp_reader and cpp_token typedefs remain part of cpplib.h. */ struct cpp_reader; struct cpp_token; Cheers, Manuel.