From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112246 invoked by alias); 7 Dec 2018 15:14:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 112231 invoked by uid 89); 7 Dec 2018 15:14:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy= X-HELO: userp2120.oracle.com Received: from userp2120.oracle.com (HELO userp2120.oracle.com) (156.151.31.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Dec 2018 15:14:14 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB7F8mSb128010; Fri, 7 Dec 2018 15:14:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2018-07-02; bh=AgiGqycatzJboSC/S5KV7R7tqvswTyq99JPq3mpjz+w=; b=WJAVsQLn4LEEOum/g6uIs22qKT1t9G0/EzJEG7yWUO30KlC0ZqGU3wF4CXRzhFn3lzQw 7lmqshczsY2PHd74+cmdPadFZekX3YZvCnEwQG+58QuOT9afUEiYVRTLMS9ZVOloa+nk owmF26XeoAwgGTsrqUYm7ufZ1vBRNeZZDWbqNs8fvJo6C6+CeBh6gPjexMUj8HHQyGo/ BoxNV4bza5Es7N6leUXdAK23iPRBjYtxVVBEYzuVH9ETkb72El4jwV3gKEljTyo7+1Ej RbQ5ltlxk3GgU89eFtWw/tpJZYh8x7gblRCGL2C4pUgz+Xa0PebJxQeS7I9ReFAaAKG9 0w== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2p3jxrx94f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Dec 2018 15:14:08 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wB7FE7Fp021092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Dec 2018 15:14:07 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB7FE5Pw026181; Fri, 7 Dec 2018 15:14:06 GMT Received: from dhcp-10-159-154-153.vpn.oracle.com (/10.159.154.153) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 07 Dec 2018 07:14:05 -0800 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH][Version 3]Come up with -flive-patching master option. From: Qing Zhao In-Reply-To: Date: Fri, 07 Dec 2018 15:14:00 -0000 Cc: Jan Hubicka , =?utf-8?Q?Martin_Li=C5=A1ka?= , Miroslav Benes , Martin Jambor , gcc Patches Content-Transfer-Encoding: quoted-printable Message-Id: <06AFB415-CB68-4CAD-A0EB-40FBB32AECCE@oracle.com> References: <8F7AEFF2-5DCE-49B6-BC9E-34FC0DEF2A55@oracle.com> <568496ae-!24cf-7453-57db-a2188d5d11c2@suse.cz> <49B97110-C7FD-4569-AE26-1B37951D802B@oracle.com> <30e99713-0a96-3acb-ea5f-8f0996be69a6@suse.cz> <5A3304F6-2084-44BA-86CB-88A657AAF741@oracle.com> <25de1f37-40b1-1834-78cc-13f89215906d@suse.cz> <06EEEEBB-40EC-47DE-BB30-22784E3E28AF@oracle.com> <20181128155203.rusncos2kiieyqgk@kam.mff.cuni.cz> To: Rainer Orth X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00466.txt.bz2 thanks a lot for fixing this issue. Qing > On Dec 7, 2018, at 7:07 AM, Rainer Orth wro= te: >=20 > Hi Qing, >=20 >>> On Nov 28, 2018, at 9:52 AM, Jan Hubicka wrote: >>>=20 >>>>=20 >>>> 2018-11-20 qing zhao >>>>=20 >>>> * cif-code.def (EXTERN_LIVE_ONLY_STATIC): New CIF code. >>>> * common.opt: Add -flive-patching flag. >>>> * doc/invoke.texi: Document -flive-patching. >>>> * flag-types.h (enum live_patching_level): New enum. >>>> * ipa-inline.c (can_inline_edge_p): Disable external functions from >>>> inlining when flag_live_patching is LIVE_PATCHING_INLINE_ONLY_STATIC. >>>> * opts.c (control_options_for_live_patching): New function. >>>> (finish_options): Make flag_live_patching incompatible with flag_lto. >>>> Control IPA optimizations based on different levels of=20 >>>> flag_live_patching. >>>>=20 >>>> gcc/testsuite/ChangeLog: >>>>=20 >>>> 2018-11-20 qing zhao >>>>=20 >>>> * gcc.dg/live-patching-1.c: New test. >>>> * gcc.dg/live-patching-2.c: New test. >>>> * gcc.dg/live-patching-3.c: New test. >>>> * gcc.dg/tree-ssa/writeonly-3.c: New test. >>>> * gcc.target/i386/ipa-stack-alignment-2.c: New test. > [...] >>> Patch is OK, >>=20 >> thanks for the review. >>=20 >> I will commit the patch very soon. >=20 > the new gcc.target/i386/ipa-stack-alignment-2.c testcase FAILs on > Solaris/x86: >=20 > FAIL: gcc.target/i386/ipa-stack-alignment-2.c scan-assembler sub.*%.sp >=20 > Like ipa-stack-alignment.c, it needs -fomit-frame-pointer. Fixed as > follows, tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu, 32 and > 64-bit each. Installed on mainline. >=20 > Rainer >=20 > --=20 > -------------------------------------------------------------------------= ---- > Rainer Orth, Center for Biotechnology, Bielefeld University >=20 >=20 > 2018-12-06 Rainer Orth >=20 > * gcc.target/i386/ipa-stack-alignment-2.c: Add > -fomit-frame-pointer to dg-options. >=20 > # HG changeset patch > # Parent 580b8c24b018674f1ffd56a9c672129f746682c5 > Build gcc.target/i386/ipa-stack-alignment-2.c with -fomit-frame-pointer >=20 > diff --git a/gcc/testsuite/gcc.target/i386/ipa-stack-alignment-2.c b/gcc/= testsuite/gcc.target/i386/ipa-stack-alignment-2.c > --- a/gcc/testsuite/gcc.target/i386/ipa-stack-alignment-2.c > +++ b/gcc/testsuite/gcc.target/i386/ipa-stack-alignment-2.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-flive-patching -O" } */ > +/* { dg-options "-flive-patching -O -fomit-frame-pointer" } */ >=20 > typedef struct { > long a;