From: Jason Merrill <jason@redhat.com>
To: Martin Sebor <msebor@gmail.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] call mark_dfs_back_edges() before testing EDGE_DFS_BACK [PR104761]
Date: Thu, 10 Mar 2022 09:17:29 -0500 [thread overview]
Message-ID: <06a1aca7-5096-8214-152d-35b2800d5ed7@redhat.com> (raw)
In-Reply-To: <e051fabe-b66d-5bb2-d317-f82a34f4088b@gmail.com>
On 3/2/22 19:15, Martin Sebor wrote:
> The -Wdangling-pointer code tests the EDGE_DFS_BACK but the pass never
> calls the mark_dfs_back_edges() function that initializes the bit (I
> didn't know about it). As a result the bit is not set when expected,
> which can cause false positives under the right conditions.
>
> The attached patch adds a call to the warning pass to initialize
> the bit. Tested on x86_64-linux.
OK on Monday if no other comments.
Jason
prev parent reply other threads:[~2022-03-10 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 23:15 Martin Sebor
2022-03-03 8:01 ` Jakub Jelinek
2022-03-03 9:26 ` Richard Biener
2022-03-03 17:56 ` Jeff Law
2022-03-04 0:08 ` Martin Sebor
2022-03-04 13:58 ` Jakub Jelinek
2022-03-05 8:08 ` [PATCH] waccess: Remove visited bitmap and stop on EDGE_ABNORMAL Jakub Jelinek
2022-03-05 10:28 ` Richard Biener
2022-03-10 14:17 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a1aca7-5096-8214-152d-35b2800d5ed7@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).