From: Jeff Law <jeffreyalaw@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>,
"Maciej W. Rozycki" <macro@embecosm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [committed] MAINTAINERS: Add myself as a VAX port maintainer
Date: Tue, 26 Oct 2021 14:28:49 -0600 [thread overview]
Message-ID: <06b4937d-c1a6-1432-841c-8bb143a02b81@gmail.com> (raw)
In-Reply-To: <20211026190632.GB304296@tucnak>
On 10/26/2021 1:06 PM, Jakub Jelinek via Gcc-patches wrote:
> On Tue, Oct 26, 2021 at 06:51:09PM +0100, Maciej W. Rozycki wrote:
>> On Tue, 26 Oct 2021, Martin Liška wrote:
>>
>>> Please remove your name from Write After Approval:
>>>
>>> $ make check -k RUNTESTFLAGS="maintainers.exp"
>>> ...
>>> Running /home/marxin/Programming/gcc/gcc/testsuite/gcc.src/maintainers.exp ...
>>> Redundant in write approval: Maciej W. Rozycki
>>> FAIL: maintainers-verify.sh
>> Hmm, that seems like useless policy to me; the "Write After Approval"
>> section used to be an exhaustive, alphabetically sorted list of people
>> with commit rights, and it still is with our sister projects binutils and
>> GDB. By removing entries for people listed elsewhere (which may be across
>> several places anyway) you require one to look for information scattered
>> around the file. And contributors to remember adding themselves back as
>> they step down from maintainer posts.
>>
>> Besides, my e-mail addresses listed are different in the two sections,
>> and that's been deliberate. Also what about people carrying identical
>> full names? I insist on using my middle initial for a reason.
>>
>> It seems like there's been hardly any discussion about this matter around
>> the time this stuff was added with commit bddcac9d1c32 ("[contrib] Add
>> contrib/maintainers-verify.sh"). What was the actual motivation behind
>> that change?
> That was only addition of a script and testcase to verify what has been done
> in MAINTAINERS since forever.
> Just look at all the commits to remove redundant entries from Write After
> Approval, e.g.
> https://gcc.gnu.org/legacy-ml/gcc-patches/2003-05/msg00366.html
> All maintainers or reviewers (global or specific) have write after approval
> rights for areas they don't maintain.
I went ahead and fixed Maciej's entries in the obvious way.
jeff
next prev parent reply other threads:[~2021-10-26 20:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 15:26 Maciej W. Rozycki
2021-10-26 15:34 ` Martin Liška
2021-10-26 17:51 ` Maciej W. Rozycki
2021-10-26 19:06 ` Jakub Jelinek
2021-10-26 20:28 ` Jeff Law [this message]
2021-10-27 12:32 ` [PATCH] MAINTAINERS: Clarify the policy WRT the Write After Approval list Maciej W. Rozycki
2021-11-03 14:00 ` [PING][PATCH] " Maciej W. Rozycki
2021-11-03 15:44 ` Jeff Law
2021-11-03 17:08 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06b4937d-c1a6-1432-841c-8bb143a02b81@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=macro@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).