From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) by sourceware.org (Postfix) with ESMTPS id 34FDD3858C83 for ; Fri, 19 Aug 2022 16:44:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 34FDD3858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=pfeifer.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=pfeifer.com Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 3750033EBC; Fri, 19 Aug 2022 12:44:37 -0400 (EDT) Received: from [10.4.1.8] (unknown [185.135.18.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id A88BF33EC0; Fri, 19 Aug 2022 12:44:36 -0400 (EDT) Date: Fri, 19 Aug 2022 18:44:34 +0200 (CEST) From: Gerald Pfeifer To: Iain Buclaw cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] wwwdocs: Add D language changes and caveats to gcc-12/changes.html In-Reply-To: <20220817172404.1025025-1-ibuclaw@gdcproject.org> Message-ID: <06d9d8d2-7a26-1a9a-b50a-b1e59b4142c9@pfeifer.com> References: <20220817172404.1025025-1-ibuclaw@gdcproject.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.09 on 209.68.5.143 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 16:44:40 -0000 On Wed, 17 Aug 2022, Iain Buclaw wrote: > This patch belatedly adds the new features and changes to the D > front-end during the GCC 12 development cycle, as well as a bullet in > the caveat section for D's new bootstrapping requirements. Nice! > + D: > + Building and bootstrapping GDC, the D compiler, now requires a working GDC > + compiler (GCC version 9.1 or later) and D runtime library, libphobos, as > + the D front end is written in D. Might we be able to omit the "and bootstrapping" reference, which can be seen as a specific flavor of builing? And put "libphobos" in parentheses, in line with "GCC version 9.1..."? > + by default, but compiles and works if --enable-libphobos is > + used. Other targets may require a more recent minimum version of GCC to > + bootstrap. Specifics are documented for affected targets in the Might we be able to omit "for affected targets"? How do you feel about + installation + instructions. instead of + manual for + installing GCC. Genuine questions, all of them. > +
  • On supported targets, the __traits(compiles) expression No comma between "targets" and "the". > +
  • -fcheck=, enables or disables the code generation of > + specific run-time contract checks. No comma (I think)? ALso for the following entries. > +
  • -fcheckaction=, controls the run-time behaviour on an We generally use US English for consistency. :) > +
  • -fdump-c++-spec=, dumps all compiled > + extern(C++) declarations as C++ code to a file. "to a file as C++ code"? > + The supplimentary option -fdump-c++-spec-verbose turns on > + emission of comments for ignored declaration in the generated C++ spec. "declarations" > +
  • -fextern-std=, controls which C++ standard > + extern(C++) declarations are compiled to be compatible > + with. It feels something is missing here (in terms of grammar)? > +
  • -fsave-mixins=, saves mixins expanded at compile-time to > + a file. > +
    • Will it be clear to everyone what a mixin is? (It's not to me, but I do not know D.) > +
  • Deprecated and removed features: : > +
  • The -ftransition=dip25 and > + -ftransition=dip1000 compiler switches have been renamed > + to -fpreview=dip25 and -fprefix=dip1000. > +
    • Hmm, so the feature as such has not been deprecated or removed; just how it's been invoked has changed. I hope this is useful feedback. As maintainer for everything D in GCC you do not need approval to commit, I'm just happy to help (from a consistency and "naive user" perspective if nothing else). Cheers, Gerald