From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mliska@suse.cz>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by sourceware.org (Postfix) with ESMTPS id CF09E395184D
 for <gcc-patches@gcc.gnu.org>; Thu, 20 May 2021 13:29:34 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CF09E395184D
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=suse.cz
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
 by mx2.suse.de (Postfix) with ESMTP id BD815AC5B;
 Thu, 20 May 2021 13:29:33 +0000 (UTC)
Subject: Re: [PATCH] Simplify option handling for -fsanitize-coverage
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>, gcc-patches@gcc.gnu.org
References: <7032aba0-c3ff-600f-f881-7f149728564f@suse.cz>
 <F342A449-4C80-4353-8EB5-4FBB1B47D7ED@gmail.com>
From: =?UTF-8?Q?Martin_Li=c5=a1ka?= <mliska@suse.cz>
Message-ID: <06da36b3-ed44-f32f-46a5-e5a491c9fca4@suse.cz>
Date: Thu, 20 May 2021 15:29:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <F342A449-4C80-4353-8EB5-4FBB1B47D7ED@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 May 2021 13:29:35 -0000

On 5/20/21 3:26 PM, Bernhard Reutner-Fischer wrote:
> On 20 May 2021 12:43:17 CEST, "Martin Liška" <mliska@suse.cz> wrote:
> 
>>   /* Given ARG, an unrecognized sanitizer option, return the best
>>      matching sanitizer option, or NULL if there isn't one.
>>      OPTS is array of candidate sanitizer options.
>> -   CODE is OPT_fsanitize_, OPT_fsanitize_recover_ or
>> -   OPT_fsanitize_coverage_.
>> +   CODE is OPT_fsanitize_or OPT_fsanitize_recover_.
> 
> Shouldn't be there a space before "or" in OPT_fsanitize_or ?

Yes, please.

> thanks,
>
Thanks,
Martin