From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 7480939540E7 for ; Tue, 22 Jun 2021 20:59:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7480939540E7 Received: by mail-ot1-x334.google.com with SMTP id j11-20020a9d738b0000b02903ea3c02ded8so22577341otk.5 for ; Tue, 22 Jun 2021 13:59:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xPZbzMgS5jCsnx7lWzu25mfdqfRV1rn5pO0oCkyFRm4=; b=IN2E4mrW9EwVJtJ5l93FAwd9AU+WXOXCpUFDXUc6R+D3zjm11ISZ1CeKZjwkqnCzpk 3G5wjS40/aSyBkVhzS65wGhA4GVs2VD0BEJ4UdHG3f1qWvoEPwZF8UVqtrwOWoEp98lx x+7vDkw1ZbEt0J1VQorBJlUv6OveaZOVCtdd6X20NHyZH+b+I8PM0dhoLY1/70SsnRmF zhT9mqDOQXGOIvFj2zK492aat8grK5HjuFBTlvzDFPofzK23COBh4CS2P7sDgX0M3nAx KY35yhEODDLZhpl6u/ChjGVhb0x8KnzEDc3YRmCX9O0HyF3HhwO9+wKY07oNUcUYL9kg 4smg== X-Gm-Message-State: AOAM533VH6/at/Gs/hmpvvzX4MDLt4Bep6h2hdS3+PUnI82PpHd8bu9H ueZp2xDldSkI/WH0VrRrRkU= X-Google-Smtp-Source: ABdhPJxMn9IKiIFLoToGyZFM+PoLggZvlSxw6K+P9gGChEl7TkipVnZuj6JRzYT1dRnqq7X8fvWlHQ== X-Received: by 2002:a9d:7f03:: with SMTP id j3mr4678054otq.235.1624395587916; Tue, 22 Jun 2021 13:59:47 -0700 (PDT) Received: from [192.168.0.41] (97-118-105-195.hlrn.qwest.net. [97.118.105.195]) by smtp.gmail.com with ESMTPSA id g38sm121267otg.28.2021.06.22.13.59.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jun 2021 13:59:47 -0700 (PDT) Subject: [PING][PATCH] make rich_location safe to copy From: Martin Sebor To: gcc-patches , David Malcolm References: <88448f63-87ad-c3a5-d38b-c94dd825e8d2@gmail.com> Message-ID: <06e83236-077e-7cd4-f795-8b9d6d9e5e75@gmail.com> Date: Tue, 22 Jun 2021 14:59:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <88448f63-87ad-c3a5-d38b-c94dd825e8d2@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 20:59:50 -0000 Ping: David, I'm still looking for approval of the semi_embedded_vec change in the originally posted patch (independent of the already approved subsequent change to rich_location). https://gcc.gnu.org/pipermail/gcc-patches/2021-June/572845.html On 6/15/21 7:48 PM, Martin Sebor wrote: > While debugging locations I noticed the semi_embedded_vec template > in line-map.h doesn't declare a copy ctor or copy assignment, but > is being copied in a couple of places in the C++ parser (via > gcc_rich_location).  It gets away with it most likely because it > never grows beyond the embedded buffer. > > The attached patch defines the copy ctor and also copy assignment > and adds the corresponding move functions. > > Tested on x86_64-linux. > > Martin