public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/6] Fix TYPE_PRECISION use in hashable_expr_equal_p
Date: Fri, 23 Jun 2023 08:49:46 -0600	[thread overview]
Message-ID: <06f0376d-f480-3122-5d90-99993fd01880@gmail.com> (raw)
In-Reply-To: <20230623082704.5D4AB1331F@imap2.suse-dmz.suse.de>



On 6/23/23 02:27, Richard Biener via Gcc-patches wrote:
> While the checks look unnecessary they probably are quick and
> thus done early.  The following avoids using TYPE_PRECISION
> on VECTOR_TYPEs by making the code match the comment which
> talks about precision and signedness.  An alternative would
> be to only retain the ERROR_MARK and TYPE_MODE checks or
> use TYPE_PRECISION_RAW (but I like that least).
> 
> Bootstrap and regtest ongoing on x86_64-unknown-linux-gnu, OK?
> 
> 	* tree-ssa-scopedtables.cc (hashable_expr_equal_p):
> 	Use element_precision.
OK.
jeff

      reply	other threads:[~2023-06-23 14:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23  8:27 Richard Biener
2023-06-23 14:49 ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06f0376d-f480-3122-5d90-99993fd01880@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).