From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 4D2C23858CD1 for ; Fri, 23 Jun 2023 14:49:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D2C23858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-666e5f0d60bso402058b3a.3 for ; Fri, 23 Jun 2023 07:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687531788; x=1690123788; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=30X9BniNrOH2O0NKUuiChTdrMJyQZCgdglTHhxGE6OY=; b=luJZKIHV6I4C0NRPtonPcWYL/YeZ1qVh9FucMqahmbun+rKDHmR++sAui7C9iihUjX 9w9YgtchfY7LGidYZ/1txe8vrkGbEOGcCwVIa193FKSpfpIWzX1glUHQxpDRtdL5mgwJ tuC1UxwGPVIL1PqvvgLqpUo91UwmwCNoRQSAZAjgHJlOZ8OCpqK8cJWrdjcaWc0hMr/I htw/C/ZU322MhigDDGc7ycFmt8/Aq1BxZsqcLo23mtU1g/rNGR8dNTsHOPsjTkDrXLy5 IV0Wcn/4B8h+Uz06jOg40CJ8uo8GQrGFBj3SSNredh9dntD7R2H91TX9poR53W98PvsO ewOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687531788; x=1690123788; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=30X9BniNrOH2O0NKUuiChTdrMJyQZCgdglTHhxGE6OY=; b=IkzsJPqsX6W88vs84QLFTLjk5ZgO7So6XmuqpKvrsJd26cNGtCDXsHE6GwxYQS77CD AMHDDkUTlzRcTvdRMZQxT3utkknYU2dIhfcjd6kdbRp4FnHN5R39E+lfoxlDmj3WlQcK jv9goKVAkrg4izpOFZU++T0c009sFo8EgU8cAaPzB8TY4qNxH71J/QKk1YpOFp+pspIJ Y3/LZUQyLIWO7/wQs0ev0qLAaM2daCk+H6s/cRD+gx3M7V93RpqsR9FNErwv56Rx2Lp+ HLe/STmrkZmDaatsQvHEp3A9KrClTbPtr+E6NLxgoUFQnfODmLpePm6YwM4vIBjsgeNs J3Ng== X-Gm-Message-State: AC+VfDz9dtrIp7zCKeiDW05N8+kI9Gng68DZt1YbjSUPF7rQrhmVnWYB 5u6Q/PJG2eGeU2wTCX+axMI= X-Google-Smtp-Source: ACHHUZ6rKrBfgL0W1PDAL1Jwon0EK6aj0L0qgMMDdgFrgMNz8+ij/ru2roEJ/Ac890iJ6IG63TyVdw== X-Received: by 2002:a05:6a20:258c:b0:123:6bd8:90d5 with SMTP id k12-20020a056a20258c00b001236bd890d5mr6862992pzd.36.1687531787964; Fri, 23 Jun 2023 07:49:47 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id iz3-20020a170902ef8300b001b3e84240b4sm7329364plb.67.2023.06.23.07.49.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 07:49:47 -0700 (PDT) Message-ID: <06f0376d-f480-3122-5d90-99993fd01880@gmail.com> Date: Fri, 23 Jun 2023 08:49:46 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/6] Fix TYPE_PRECISION use in hashable_expr_equal_p Content-Language: en-US To: Richard Biener , gcc-patches@gcc.gnu.org References: <20230623082704.5D4AB1331F@imap2.suse-dmz.suse.de> From: Jeff Law In-Reply-To: <20230623082704.5D4AB1331F@imap2.suse-dmz.suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/23/23 02:27, Richard Biener via Gcc-patches wrote: > While the checks look unnecessary they probably are quick and > thus done early. The following avoids using TYPE_PRECISION > on VECTOR_TYPEs by making the code match the comment which > talks about precision and signedness. An alternative would > be to only retain the ERROR_MARK and TYPE_MODE checks or > use TYPE_PRECISION_RAW (but I like that least). > > Bootstrap and regtest ongoing on x86_64-unknown-linux-gnu, OK? > > * tree-ssa-scopedtables.cc (hashable_expr_equal_p): > Use element_precision. OK. jeff