From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 3CC583858428 for ; Fri, 3 Dec 2021 02:42:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3CC583858428 Received: by mail-pj1-x1035.google.com with SMTP id nh10-20020a17090b364a00b001a69adad5ebso1302450pjb.2 for ; Thu, 02 Dec 2021 18:42:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sQ765a35ADjZkwaMuokxFUFfHjJ2dKYwifxiEegOjZM=; b=1uXBGX2VDZPCJ/fBNsLxwQ+XPnD8k2idlYMIHhemjXA6sIax3FW8JHO74KPJt+00yh lTa65Rkp/4z4PkyNcoZ48lk4DA/sCradHrEFA1e+aPTe5S4abWdCSKjd/LSKF8Eaf9ku aU8+HB8gN96GdA5W97jImEryx/Rtj2qxY1a5xFwI7A371KEqoVVS2yRPgizGIjqRj1At VEVwVW7rCK8VLJLoy5d6KXBWIEypQAw6ypxNVboD7IiWvS/buAqMDe4PYWEKr38QsuaW Xw1v5PNPtpntfrln7Rz76JQMYEfkWuY9lQDNlA3RcUhdqNh6YjgZzUCwPDbztLprHP7y X/Og== X-Gm-Message-State: AOAM532ovdIbslQXGGG+AXlVuBhH2av1tDNMwzkFrYdKuxyRhYkK9zkD Bb+Z6fbrrGJwkIz3BYTK6rg= X-Google-Smtp-Source: ABdhPJwrYe02Z6uMlWzrjvumGQXUn/PXL+rXQUxkdMD1TD55CzN5HiXHBIq7Rrw2cllXpDMUTwXdOQ== X-Received: by 2002:a17:902:9a09:b0:142:82e1:6cff with SMTP id v9-20020a1709029a0900b0014282e16cffmr19875901plp.47.1638499363222; Thu, 02 Dec 2021 18:42:43 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id o15sm809110pgk.7.2021.12.02.18.42.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 18:42:42 -0800 (PST) Message-ID: <06f23f33-fdc2-7662-21d4-931a812ad7ba@gmail.com> Date: Thu, 2 Dec 2021 19:42:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: PING^1 [PATCH] Add TARGET_IFUNC_REF_LOCAL_OK Content-Language: en-US To: "H.J. Lu" , GCC Patches , Richard Biener Cc: Michael Meissner References: <20210620021035.450959-1-hjl.tools@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 02:42:45 -0000 On 7/6/2021 5:47 AM, H.J. Lu via Gcc-patches wrote: > On Sat, Jun 19, 2021 at 7:10 PM H.J. Lu wrote: >> 1. On some targets, like PowerPC, reference to ifunc function resolver >> must be non-local so that compiler will properly emit PLT call. Add >> TARGET_IFUNC_REF_LOCAL_OK to allow binding indirect function resolver >> locally for targets which don't require special PLT call sequence. >> 2. Add ix86_call_use_plt_p to call local ifunc function resolvers via >> PLT. >> >> gcc/ >> >> PR target/51469 >> PR target/83782 >> * target.def (ifunc_ref_local_ok): Add a target hook. >> * varasm.c (default_binds_local_p_3): Force indirect function >> resolver non-local only if targetm.ifunc_ref_local_ok returns >> false. >> * config/i386/i386-expand.c (ix86_expand_call): Call >> ix86_call_use_plt_p to check if PLT should be used. >> * config/i386/i386-protos.h (ix86_call_use_plt_p): New. >> * config/i386/i386.c (output_pic_addr_const): Call >> ix86_call_use_plt_p to check if "@PLT" is needed. >> (ix86_call_use_plt_p): New. >> (TARGET_IFUNC_REF_LOCAL_OK): New. >> * doc/tm.texi.in: Add TARGET_IFUNC_REF_LOCAL_OK. >> * doc/tm.texi: Regenerated. >> >> gcc/testsuite/ >> >> PR target/51469 >> PR target/83782 >> * gcc.target/i386/pr83782-1.c: New test. >> * gcc.target/i386/pr83782-2.c: Likewise. This is OK.  Please re-test (I don't expect problems, but it's an old outstanding patch) & install. jeff