From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93312 invoked by alias); 14 Jul 2017 18:18:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 93302 invoked by uid 89); 14 Jul 2017 18:18:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,KAM_ASCII_DIVIDERS,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jul 2017 18:18:34 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 445D33C58; Fri, 14 Jul 2017 18:18:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 445D33C58 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 445D33C58 Received: from localhost.localdomain (ovpn-116-196.phx2.redhat.com [10.3.116.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0379E67CD5; Fri, 14 Jul 2017 18:18:32 +0000 (UTC) Subject: Re: [PATCH] Remove Java references in source code. To: Rainer Orth , =?UTF-8?Q?Martin_Li=c5=a1ka?= Cc: gcc-patches@gcc.gnu.org References: <93263f75-165a-5512-de4e-3d5c6eacb388@suse.cz> From: Jeff Law Message-ID: <070b53b6-3ddb-cf65-4871-6076d4406c22@redhat.com> Date: Fri, 14 Jul 2017 18:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00863.txt.bz2 On 07/14/2017 11:43 AM, Rainer Orth wrote: > Hi Martin, > >> Hello. >> >> Patch removes some remaining references in gcc/ subfolder. >> >> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > not enough, it seems: this patch broke Ada bootstrap at on > x86_64-pc-linux-gnu, sparc-sun-solaris2.12, and i386-pc-solaris2.12 > (probably everywhere) during stage2: > > +===========================GNAT BUG DETECTED==============================+ > | 8.0.0 20170714 (experimental) [trunk revision 250207] (x86_64-pc-linux-gnu) GCC error:| > | in gimplify_save_expr, at gimplify.c:5805 | > | Error detected around /vol/gcc/src/hg/trunk/local/gcc/ada/butil.adb:40:31| > | Please submit a bug report; see https://gcc.gnu.org/bugs/ . | > | Use a subject line meaningful to you and us to track the bug. | > | Include the entire contents of this bug box in the report. | > | Include the exact command that you entered. | > | Also include sources listed below. | > +==========================================================================+ > > Please include these source files with error report > Note that list may not be accurate in some cases, > so please double check that the problem can still > be reproduced with the set of files listed. > Consider also -gnatd.n switch (see debug.adb). > > /vol/gcc/src/hg/trunk/local/gcc/ada/system.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/butil.adb > /vol/gcc/src/hg/trunk/local/gcc/ada/butil.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/namet.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/alloc.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/hostparm.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/types.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/unchconv.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/unchdeal.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/table.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/gnat.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/g-table.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/g-dyntab.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/ada.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/a-unccon.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/output.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/s-os_lib.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/s-string.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/s-stalib.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/s-exctab.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/s-unstyp.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/s-conca2.ads > /vol/gcc/src/hg/trunk/local/gcc/ada/s-assert.ads > > > raised TYPES.UNRECOVERABLE_ERROR : comperr.adb:406 > /vol/gcc/src/hg/trunk/local/gcc/ada/gcc-interface/Make-lang.in:119: recipe for target 'ada/butil.o' failed > make[3]: *** [ada/butil.o] Error 1 > > Reverting ... > >> * gimplify.c >> (gimplify_save_expr): Likewise. > > ... this part allowed the bootstrap to finish. If you wanted to commit that change with a comment somehow indicating how the code is interacting with the Ada front-end, consider it pre-approved. Similarly for you Martin. No need to get approval for putting a chunk of code back in :-) jeff