From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 00F09385829F for ; Tue, 4 Oct 2022 15:43:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 00F09385829F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664898187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fOCfRYwIxC8vmH+FcN3cR3BREy558ndGgNw2ECbq6iM=; b=JRDMlPfrFcXsO5PezufYgMxUBeZ9RPbj5mZ5XXo36lfvXJK4oWNxfi5lWvuxeJJKc4P64r tYas2lLBuNI1SVFVR0STmcKcCOxc64w7rIGstZLQvcN4zL+/1Nua9C52Xci/EDdWp2Qi8H sBi1Skv5UDQvUNVX3UPW9kkxlbzg5W4= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-116-q5SwgwfMP7ujKnqDrFgLew-1; Tue, 04 Oct 2022 11:43:06 -0400 X-MC-Unique: q5SwgwfMP7ujKnqDrFgLew-1 Received: by mail-qt1-f198.google.com with SMTP id l11-20020ac848cb000000b0038f4394d93aso8667qtr.21 for ; Tue, 04 Oct 2022 08:43:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=El2/WMYYtvqhkxTVHtPWhXIL0sRXJdnRBzY6bbUtdtY=; b=AadTeE7cP5hFo36k2AGGqJDSnPa0JGECs01AMWGcLt9IHcpdeXfLKBBFEr9i7fYGMm 6eai1Bl/zz7ni4v4Y5PcPbh1rEaeM61UIl5OUlMTjke3cKW5+0SMI3TOiQfk/Uec2x5t 6nFmtxqS/OBKe8LjZ1m5ZkyE3I9m6BwMclQRua0UUi4CQH29SAJ46jiJKdEL/LH6PFHs RPq5AR8jUlz3KZjUE3KSJFSnogQsXrtErxIC2wqSBwAtxm/fyV5sCFv+A0VuAKZUa6th pzY4gZwiKheHNv4BFq740xjHqCx7KIzUcJ/czsqbkRV9cYJ6IQ2fU5icnqClXcidEfvA WyWw== X-Gm-Message-State: ACrzQf2E82SvsSkTw58lAEen0sK62jAQrdkgAAUc5GCVFJEAQFUrMtSD 2rXuwWaq2LU8kXwnpsXMqjt+od7iMsWhQMOkctNDM4/xvnLa/V/50DeIY5A2wi06Zv8AA3v1+AT MYtHPQXwbP5dm0Dy26w== X-Received: by 2002:a05:622a:50a:b0:35d:5d18:c2a2 with SMTP id l10-20020a05622a050a00b0035d5d18c2a2mr20129584qtx.515.1664898186265; Tue, 04 Oct 2022 08:43:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4J52YBMIEPOiOcMPZbdOaoeUp6iDSSPzs7NVzMWx+tqA+n0gDPDS7ESBSG0HuZ/DAo2C+Z3w== X-Received: by 2002:a05:622a:50a:b0:35d:5d18:c2a2 with SMTP id l10-20020a05622a050a00b0035d5d18c2a2mr20129568qtx.515.1664898185987; Tue, 04 Oct 2022 08:43:05 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id l12-20020a05620a28cc00b006d1debe2637sm13217681qkp.11.2022.10.04.08.43.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 08:43:05 -0700 (PDT) Message-ID: <073c025e-cdcb-e332-a55d-6138f8118364@redhat.com> Date: Tue, 4 Oct 2022 11:43:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH] c++: install cp-trait.def as part of plugin headers [PR107136] To: Patrick Palka , gcc-patches@gcc.gnu.org References: <20221004004216.1994023-1-ppalka@redhat.com> From: Jason Merrill In-Reply-To: <20221004004216.1994023-1-ppalka@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-26.5 required=5.0 tests=BAYES_00,DKIM_INVALID,DKIM_SIGNED,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/3/22 20:42, Patrick Palka wrote: > This is apparently needed since we include cp-trait.def from cp-tree.h > (in order to define the cp_trait_kind enum), as with operators.def. > > Tested on x86_64-pc-linux-gnu by doing make install and verifying > cp-trait.def appears in > > $prefix/lib/gcc/x86_64-pc-linux-gnu/13.0.0/plugin/include/cp/ > > Does this look OK for trunk? OK. > PR c++/107136 > > gcc/cp/ChangeLog: > > * Make-lang.in (CP_PLUGIN_HEADERS): Add cp-trait.def. > --- > gcc/cp/Make-lang.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/cp/Make-lang.in b/gcc/cp/Make-lang.in > index 38d8eeed1f0..aa84d6827be 100644 > --- a/gcc/cp/Make-lang.in > +++ b/gcc/cp/Make-lang.in > @@ -39,7 +39,7 @@ CXX_INSTALL_NAME := $(shell echo c++|sed '$(program_transform_name)') > GXX_INSTALL_NAME := $(shell echo g++|sed '$(program_transform_name)') > CXX_TARGET_INSTALL_NAME := $(target_noncanonical)-$(shell echo c++|sed '$(program_transform_name)') > GXX_TARGET_INSTALL_NAME := $(target_noncanonical)-$(shell echo g++|sed '$(program_transform_name)') > -CP_PLUGIN_HEADERS := cp-tree.h cxx-pretty-print.h name-lookup.h type-utils.h operators.def > +CP_PLUGIN_HEADERS := cp-tree.h cxx-pretty-print.h name-lookup.h type-utils.h operators.def cp-trait.def > > # > # Define the names for selecting c++ in LANGUAGES.