From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id F0F203858D20 for ; Thu, 26 Oct 2023 16:44:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0F203858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F0F203858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698338684; cv=pass; b=Mss9lalpy6SnsUgGv5RWpjE7OZXd/cnKJ67pcAUjItunu+RpLz6Iz4lL7bz/I3nPmXJOv3hjEqTdxbLEKC8k8uKOXkhx2/zvZ29eSnW+GBD0VvxnEva03yo26SNfEy1qCgKR5R0+v9epL7SysM6T5LH5xnvKKpPWJLbxQOCZxQE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698338684; c=relaxed/simple; bh=ncKNjQphf6tt1djTMv0LHxzICVHE7QCeY9w3s+hK1Ic=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=guios+j+XRwYc3pkQgl3Y3mBejjxUmyPPSt39SFJAPQNXultEED/LvTRdV0b2z2oXexE8xNOWtYujIsk7yheyR197DI6oFkUTsiRHPK0aSQetUrATjE8T/ZfjNmmnEwKPD58j9aIjQr7A8nbmv46rZLKXQihGnDAcb60jm+KUOc= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39QDimoH028763 for ; Thu, 26 Oct 2023 16:44:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=6N597J6o+q+iT22jNZe3+RNua5a4Mrzt1Jty3WnsaU4=; b=gS0RYvWupmOJaazyBT8F18PyUQUxYalSiPkPTGe9dnDU+hYLQUCGpoJ/txsMrjvjHjLV HBbbkRy7NWjbtU6fVYesieeUiEn45btkCaUeDLySfsfkcpZ8O/ZOSDSOCM0gDlMxKs8H RiK46HI8/n5QJnNf2d3F/5+Sw1uGrEUKsa8ioFZ/Uu/d2ZwPhkEF97+xB0FnoPCVvbK6 2hA5zwaC3eZHxkyQmiaVT/wB4bVKuwxTkOW06KQbwZHphhVkmSpUNLDF4jHQT4pnX2/Z a3G+ChyMwKUsfPd4DKoEcISM0KOqBJLBdVYbYa5+id/dd+SrRyce9NpkXEluBkWsI2fK ng== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tv581ugub-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 26 Oct 2023 16:44:41 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39QFuF0J034598 for ; Thu, 26 Oct 2023 16:44:41 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2040.outbound.protection.outlook.com [104.47.57.40]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3tv538ec8k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 26 Oct 2023 16:44:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuIdNkkhh2tIMdOkc1lbKyyzVF+TSz/xAKqE6bOWxXxfcaT/W172gztP9RMDbZwtyCY2azv5FNbM7dcvnmD8YMJNThM2WPovcWp1M2nQ5oJNYIJ7e9TE07SPVUiX9Gl9pqlf6JIsDFQpvC77jQi71NpGzqr1Jhbrzej3qmWzCS6x2gtgJ+QlVVFQ9QD6AszWpnSUL4dCfuotPjpxdxustNJr2OOyOBSUP+qfYdLuv6PE36l9E2TudNo2FCqnqluI9yKXArLwemFobcaTJOKKmMZd3kS4AnUTDsraiKFGyoEpqEiRDJiA8+dc36ttn5XOCJEnCP+LjJEP4RSR1mnspA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6N597J6o+q+iT22jNZe3+RNua5a4Mrzt1Jty3WnsaU4=; b=S7mybBRZvJgmIe74MPWDdifGDV2MQcfaZQbMNocMzrI6MHEnhROaF8GACM9Sd9P5Tq0qHAiVDgJvC7fFfieSeSfGIXXn+nQxOBcuNfbhSpqdEu293x3HNf8MaFsod+cqZbdhs7kXJ7VRNfxepbJjUZBg7nxTbvRy3/IiPtQgT4nqstAMhkDW4ImlSucajI6VR3LO8FpVc/a6P4eX/lW3WQt3tyMTziRi/ZzrevFc6A8ZUxvrfGzgHp8PmUZsCEtSg1r26Nguzo+OcekDLT5cddd9iuLg/sgdGp8lufOvE2p2UQZXU0ZwII1fChYR3R2gGYXAnGFMucAS3E1LSq1EiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6N597J6o+q+iT22jNZe3+RNua5a4Mrzt1Jty3WnsaU4=; b=dlXAePE5lnOKyzS2l1dd09s2HNuooJQsl2avIOvNJLeNOyf48vACEPHqL4E/Hn/XyYCPX/nvCRXhc5sozJ6rdpBknim57LPtN7C1TXDXd6yjObyiYYnhKkU1RCvCzeJHK5uLszvtkfoiR/mjref7/QLA5snPPI3T9iBxZ0D53L4= Received: from MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) by LV8PR10MB7941.namprd10.prod.outlook.com (2603:10b6:408:1fc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29; Thu, 26 Oct 2023 16:44:36 +0000 Received: from MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::d8:db85:8025:ed64]) by MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::d8:db85:8025:ed64%6]) with mapi id 15.20.6933.019; Thu, 26 Oct 2023 16:44:36 +0000 Message-ID: <07453cca-b86b-41f2-aa67-853a33fd46f9@oracle.com> Date: Thu, 26 Oct 2023 09:44:31 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] bpf: Improvements in CO-RE builtins implementation. Content-Language: en-US To: Cupertino Miranda Cc: "Jose E. Marchesi" , Elena Zannoni , gcc-patches@gcc.gnu.org References: <875y2ta0bf.fsf@oracle.com> From: David Faust In-Reply-To: <875y2ta0bf.fsf@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0265.namprd03.prod.outlook.com (2603:10b6:a03:3a0::30) To MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3213:EE_|LV8PR10MB7941:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ebf57a5-3f34-4991-c5fa-08dbd642d65f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vhaJWfUGtOhxFARylASOynDKlzQIsYlxMlBprBZDDi6k+YdSE1zx/joG00hT6UgciAVb113JvV3OU1cpZFYlO0RtB44LeRJtMU+5KsaMLK51wxr0Sp8feRTil33l6tOOnCGlMy6ZqGns5gwvRXJs0aAsxc6y3jxHKdUut7T7cStHf+OXbYw8XTJH9F/jKU+AGy2/4EX2ilMqC8JH482FNf+Ru5DWVgVAzSKZxs8duM8DTB9YlAOMVJsM3dXuudsTc4CtL3AM7uFYA81q4bhS2FZYzto40SXA5YVBqDPJgJ3LAH3lESej4/KvHJiT04Vd3Yh6qCLI5KK4fOP6prn1o9rVRJMUeHbq2zofSatJV2A7NSJ/O5De+Eyk4Oq2XTcGXOCx2MFnywBdmjCWD97LKvBp+vRyDlhrMWP4iDZDvAFpX0fuan5R5rmTkrahmeYHB5BDgnyZv0yz2tFirrRqe+g4EDluLUNJ6mp9FN9/It6YAabY2D/NO7qvBsZciDub/iS8CyxQUT4cy4GHG6xReXRDfZdgMAvwLOdDYMXZNwttm7sIfN5I4N2S4omPvPOySBiLfGWxPSOALDaLcpdLLmzPls11VTHHDuX7bamxqgPXAM4xJLdcsnFdLP0er9n6iJYvK0wTLa7fgbmRliXu+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3213.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(39860400002)(396003)(376002)(136003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(2906002)(31686004)(53546011)(86362001)(6506007)(2616005)(6512007)(38100700002)(31696002)(36756003)(66556008)(26005)(478600001)(44832011)(4326008)(41300700001)(66476007)(6666004)(83380400001)(6486002)(8676002)(8936002)(6862004)(5660300002)(66946007)(37006003)(54906003)(316002)(6636002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUFCOTJRWGdpeisrbmx5WnZWY0lKOHlJaWJjeTJJRGRzZVdXcDhpWElyVk5S?= =?utf-8?B?R25CbGJSSS9lS3ZNWHEyNUFSLzJqcndNMERsTW9vZW1rc2FhbURRcjdleUZ4?= =?utf-8?B?OXdUWXJsZTdLWDlLNnlDTkJlVnFySXhWeXJ2UnVKYStHNkNTNEU0UFpHWGxZ?= =?utf-8?B?ZjR6djU2amZrN3hNczlnL1g0ZnczaFhERXlackV0UDZSb2NYY2s1dFZZQzRj?= =?utf-8?B?elk0aU9ZQmhlZnZwcnJRZks5QmFWSW83UytncmlRdmNpcndtbEY0U1RxVGlY?= =?utf-8?B?MFRuc0ptdjlBMnQwNUN5U0Z6K1U1ZGN2d3FCeFhGVzZkYnp4Wmw2RThZUDhS?= =?utf-8?B?SFBEMkEyS0ZKSWcrbW41Nnk2cHhDSW5pK0Nyb0c0YitodStJK1JNU3BEMlBa?= =?utf-8?B?QWpOcnQzMW1XeVlJdVZFM1lseHZrYjBqOTM0OERPWjZpWUE0c1BiYnZRMmhz?= =?utf-8?B?N0YxbGFTWWltWmptaFlKd1VZOHB2cDdQRndJR1BlZEVKbHpkTmp2dGpBK0ZR?= =?utf-8?B?b1VkQWR5RzNMTzNJdUJodmE5bmpMYW4rYjdxdkdQaUVBSkZibkd2RDFFd2oy?= =?utf-8?B?aEd1azZkRk5BYmFFVVozdzVIQlZDenQ3VG5wc3k3a0dlZ1dUSE9CUTdFYUF3?= =?utf-8?B?V2VJV05oaFBzY0lDazIvV2g2UEFRTFUxNXVXUVYrMTU2V3lGd0o5MU5YOFlM?= =?utf-8?B?bzZrUStIM3lMVjhxbk9WWEJPa2NteDVBNDdpL0ZRdHNld1h2RURJNFZ5OG1r?= =?utf-8?B?Z2owY1hRdzBzRzFlRmFlSVp5enl5cFJoZlJzdytMaTg4UDNCQzdFc1JmWWZ2?= =?utf-8?B?UmpEUjh0YW1KSW5MRzZDVWxqOWJzYnFabGpHMlJJQWIyNmZnZG1id3Q0Ymty?= =?utf-8?B?b0hoUlJjQm1Id1J4Q0VKSkhhenhpTGxLd3RZTmRJR2pJNEJRN0crc1JOcitP?= =?utf-8?B?Mm9TQjV2bnhIZnZjTTZqNWczOGJKWlVoYmlMYjJQWC8zSDdsYWNDTkpkSkxp?= =?utf-8?B?bEZUZlByTE1OMTZ0VXNPeHN2T2VSVTBxVHgzWnZQYVZtSVUxbGNkVm1ubnBq?= =?utf-8?B?bzRkcStZME5yMHlGb3JPbVBwNEFleDZmMzJnaDJsUnZhWkQ5MlZoOUVOTS9m?= =?utf-8?B?bnRQeUNmR3BzQ3lKVnpFNVZ5QVNyWE9JMUphTkdIeWZFZ3lSai90dWdrQXJw?= =?utf-8?B?QnUwbWhrTnlqb0FXSS9pVzFISUxpYTFOWWs3S1l2aEJ0UHMzeUowQlU4MTdB?= =?utf-8?B?NXA1ZXgzeEVIaG1zcEZ6eVUyaWVTVm1IVzhXTU5tcVRMUUtXK0x2M2V2eGc0?= =?utf-8?B?amNrOFp1TExrTFV0U0pLdmtDOVdEWEtOWHVYZG9GbEkvNVU5ZFJrdEpCUTEz?= =?utf-8?B?bHpoSVc4ckdvRGZJTVRyQzNhWFdHQ2M5Uko4RUtSZld0QnJaSHYwcE5Malhy?= =?utf-8?B?NmFicVFxbWppRHphS3Q3bDB3S1YwT3RSK0p4aE5xRmVTdENKaFc4Q1Y4SzU1?= =?utf-8?B?Yjh1Sm5LVzQwK0UwZzFPZGg4VzRoQ3RyMjc5RlJUTVIydndnbEhTVHNpL0Vj?= =?utf-8?B?emI5WU1udDI0ZDc3WGpzOGdNOXI5TExkUHBpTWxnOXZ0dzRQZUlyUHkvbjd3?= =?utf-8?B?ZDRhSUlNY1hBTzZ5ZFhpTFhEeGRSU245bGhwZHJNY2VQTTJKR2tPd2oyTTda?= =?utf-8?B?elUyVHdsNzRGYi8yRURYTTd5SnhGT2JsN3ZLdTVmbHBLN3Y1UWNWaDFGL0cr?= =?utf-8?B?b1kxWlN0cGlVanEyVjJURUhGc01oajFUbDZ3SEo2N25aN2RZdlF0aXJLSnll?= =?utf-8?B?WmNDRHdwZnlOaVFZYUJTb1lSVmpNbU9uWFQ2TmR0MkZ5a1JmdTNLb21lZm9i?= =?utf-8?B?L2NySCttcjg4Q1BVeG9UdVZhdGUySjJsdTJzODYwNG1JTHRVNGdNbk9KQklz?= =?utf-8?B?VE9uTmE4QU1wVHBIU2J6eHIxUmtFbUg1SWIvWFFURm1sajNJM1I1ZUp5WE9N?= =?utf-8?B?S09KTTAxT29scjVqcUlMdmcvS2JVWmE5VjJyMUExL2szTmxxbzZiNHVBZW8z?= =?utf-8?B?SkY1aTlNdC9jN1FRUVRCOVZKeHBBVEFiNGd1M3dNMklsNHZwQld6Mys1Z2dq?= =?utf-8?Q?SuxNTTaomLejd2w3VWCvAws1t?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: X3WBCe4y9JN1BxNsX0wJNS5dQhBRXgx4Gx1edIuGVYJJP5pwV3ILfwuO5hZRMzrOwVRgrKhP3RHhX7JHwR6GNu18ny0VRIwCQjEWg0h90JvvtlsvCmt3RcDQGgmfhzPZ014XhSZ7NN01EtaG5Fnj+j7RGZepoBtM5xQQ6VU3s1bM4Pe8ZjB3/vKRXjkCj3N35Nmp7IZPkqzQG4T1/Zl2XTb0A8lcd6Mouw1kA/nXMhQIhO/975dqgFW39ayY/QyA/IcWDi0Y50ua4Q1p6lC+CtIN0UpueUEO54LY0Mq7f4XcHEmXQ+7Armm3eIavL+Ca7IUYUirlgTKUKtnz+NPWabXFsDqunUlTiuxBKwUuCxWOys118IZUDD4xH2xyI2u/exYVd0JcxL0UcyqtfY/TizukT+jktwltF3ey6tnq+MtbhO6w98hBUQOY+gLx6n3GzDzT3tWrW45KYmFZlQkogv5iChIduem6ZC8j0a7RY7ZCHkEL0StOiC2BSoO3wv72Di71AkBdKrEmpKAaNoS9p4GgUQF5y/35D1/9S4+ZuCwLWGnuPSGGShw+MHoVDbmIWd1QreCJL0llcPH21lbk0x1bBh5wvjf0B+wR/q0yEttbwo+ZXSOMwyc8lO/d7Y868QJQNBW9H/2OKTFuDR5XlK3mVjOjxVy7MdOK9KmUQM2oQLBZps/0ACyS74kjXPckX7RtU5zN1UplZIeketiu7tIltvQmf9uX6mN39tlxWrVkaUEsNO2n5mo5aDWLT6A2 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ebf57a5-3f34-4991-c5fa-08dbd642d65f X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3213.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 16:44:35.9341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: szS/g3kLNBIJI9s3rMrGc24XsU9QWoodDhsuff8YUbUv0wj6nK9eAIsdc/eTcGOk+gNhYc+2vSzLXJTu3n7pTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7941 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-26_15,2023-10-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001 definitions=main-2310260146 X-Proofpoint-GUID: t8sVFoJeuzibqi7PvQ5S1wJ0xz9N-8l4 X-Proofpoint-ORIG-GUID: t8sVFoJeuzibqi7PvQ5S1wJ0xz9N-8l4 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/26/23 08:08, Cupertino Miranda wrote: > > Changes from v1: > - Fixed Davids remarks on initial patch. > - Fixed mistake with deleted '*'. > > Changes from v2: > - Reversed return value for bpf_const_not_ok_for_debug_p function. Hmm.. > +static bool > +bpf_const_not_ok_for_debug_p (rtx p) > +{ > + if (GET_CODE (p) == UNSPEC > + && XINT (p, 1) == UNSPEC_CORE_RELOC) > + return false; > + > + return true; > +} > + > +#undef TARGET_CONST_NOT_OK_FOR_DEBUG_P > +#define TARGET_CONST_NOT_OK_FOR_DEBUG_P bpf_const_not_ok_for_debug_p -- Target Hook: bool TARGET_CONST_NOT_OK_FOR_DEBUG_P (rtx X) This hook should return true if X should not be emitted into debug sections. As written now, won't this cause all ordinary (non-UNSPEC_CORE_RELOC) consts to get rejected for debug? ("regular" debug i.e. DWARF, not to be confused with the BTF.ext holding CO-RE relocs). I see other targets implementing the hook returning true only in specific cases and false otherwise. The implementation in v1 makes more sense to me. Could you explain why flip the return value? > > Changes from v3: > - Fixed ICE in two bpf-next tests: > - if (!wi->is_lhs) > - core_mark_as_access_index (gimple_get_lhs (wi->stmt)); > + tree lhs; > + if (!wi->is_lhs > + && (lhs = gimple_get_lhs (wi->stmt)) != NULL_TREE) > + core_mark_as_access_index (lhs); >