From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id 1704A3858D32 for ; Thu, 13 Apr 2023 04:05:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1704A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102d.google.com with SMTP id l9-20020a17090a3f0900b0023d32684e7fso5357501pjc.1 for ; Wed, 12 Apr 2023 21:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681358711; x=1683950711; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YogSK6iw3q6jwbKJ3umG4rhDOWAB1ELSjjWX3REEq6A=; b=RGxI2vEcIGCYqT4RIIwyn6hw3lsG+wUMD9rFvfrW+jxp23o+aDb+Y94Vix4GNMOgUp N49YHbRPduvPWRUgqvMMAC1RYglvqCqVTARo/33Voxo6o8+BOyEC1vAOXcJkVK7BZt1V 1hWI87yERAHdpK6x8KE98jN9qHR9AVM/t1FOrsimLwUhTWiPZ7TuzMw77tU0blqZnjDA jeaA8BhEoGhyNud3YeHCgLN/0Ku+ZlMhy152d10iDniF9ZXc58txCnQFsE8vlefMkDw8 1PATewtAFUriMh0/4UXE3KbYGzU5m7n+E6FjinxkzKuORFUMh52eOzz02r7B5ujax9Dk 7Q3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681358711; x=1683950711; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YogSK6iw3q6jwbKJ3umG4rhDOWAB1ELSjjWX3REEq6A=; b=NMyrk8OZfETU1bEQE88hj2M8+6M52xZeYVT/IhpiWa7ddFokfrk3gLPXYq4D7VqF4C G8VcEAKWXbPd8gmdphTp5POUchJIPbOFjPTAlfTpVMsISLTH5YUYiU75T6fM0SPLJ54O bqf+Oh+pSpDJhwzefNKidkB4AiELrLeDGKeo6695BWZLyrvsUCDhuJQSyKiRIuiz/zKP R09+J8eCwCfe2ZV/RyQNA7kUJg51HkHKydEw2ma5zY5Vof7dW7NyQJ9bXCmyu0n6Mbi7 hoUpu/pKT7Gax//SaXeVPsZoPxrpv8Zsue9pF+Lx7pX/DzUaKTZUPWmE36eT36xaWSbu 3yuA== X-Gm-Message-State: AAQBX9e0wuNk3wJ6r6fwo4lBnmCZj993XZf9JCEYYJDakiQbfQTx+Kl8 Osp7fkvekJcSLSjM9dxcch4= X-Google-Smtp-Source: AKy350aGkriqwIz5c/N0I6z0Eo2Q1j8jHA/59QHYqbuE6npMz5Z0lcKBqs9z6/whP4nMH6ikUxD/2g== X-Received: by 2002:a17:90a:c591:b0:23f:a4da:1203 with SMTP id l17-20020a17090ac59100b0023fa4da1203mr494125pjt.19.1681358710665; Wed, 12 Apr 2023 21:05:10 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id jl4-20020a170903134400b001a52abb3be3sm359554plb.201.2023.04.12.21.05.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 21:05:10 -0700 (PDT) Message-ID: <0760f780-ba7d-3476-1d9a-7b5f3063d63b@gmail.com> Date: Wed, 12 Apr 2023 22:05:08 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] combine, v4: Fix AND handling for WORD_REGISTER_OPERATIONS targets [PR109040] Content-Language: en-US To: Jakub Jelinek , Segher Boessenkool , Eric Botcazou , gcc-patches@gcc.gnu.org, Richard Biener , Richard Sandiford References: <2220543.iZASKD2KPV@fomalhaut> <3412470.QJadu78ljV@fomalhaut> <8d3c3861-c291-e762-a2a8-0b520f39a7e3@gmail.com> <965831db-ac9e-cc5e-3459-08b6b70fd577@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/23 10:58, Jakub Jelinek wrote: > On Wed, Apr 12, 2023 at 12:02:12PM +0200, Jakub Jelinek via Gcc-patches wrote: >> I've tried the pr108947.c testcase, but I see no differences in the assembly >> before/after the patch (but dunno if I'm using the right options). >> The pr109040.c testcase from the patch I don't see the expected zero >> extension without the patch and do see it with it. > > Seems my cross defaulted to 32-bit compilation, reproduced it with > additional -mabi=lp64 -march=rv64gv even on the pr108947.c test. > So, let's include that test in the patch too: > > 2023-04-12 Jeff Law > Jakub Jelinek > > PR target/108947 > PR target/109040 > * combine.cc (simplify_and_const_int_1): Compute nonzero_bits in > word_mode rather than mode if WORD_REGISTER_OPERATIONS and mode is > smaller than word_mode. > * simplify-rtx.cc (simplify_context::simplify_binary_operation_1) > : Likewise. > > * gcc.dg/pr108947.c: New test. > * gcc.c-torture/execute/pr109040.c: New test. Bootstrap of the v3 patch has completed. Regression testing is still spinning. It should be done and waiting for me when I wake up in the morning. jeff-