From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 32D5B3857B98 for ; Mon, 14 Nov 2022 16:56:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 32D5B3857B98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102c.google.com with SMTP id l6so10881453pjj.0 for ; Mon, 14 Nov 2022 08:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SKcj+/VyBXdi3v224cSvq4T6zDzW7KzMGif1v4E4gOQ=; b=GzISyRd9voEu2fAR0vizR2PwY0Hxncny+Eejt66RbVdOgbAG+StE99bk8WTR+WI0WU TLlQpbnnXZH68+j/i8C3a3mLUq6Tb4I/S7odJQOUTWkzTkDo2ggQqRgaTbmbPFcQe8/b R0R+xmY85sMo9ibu+BNngaLXQlnuPBduxaItS28zJ7lp2XrFugACMxCN5ZHO7Pyk2p+D hcjronhKX0nG9tNRUM/BBDErQ035xv48BQAhIC9TpuFlBvDD+kuhLo7mRmBoT8o0ces9 UX+64cGVY2wmdWdEp43UJg0auvgz2JiPjXMyz+CCfoJgCDeH9g+6FkecIKyXGTW64DPy wLUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SKcj+/VyBXdi3v224cSvq4T6zDzW7KzMGif1v4E4gOQ=; b=WNHo9CJU3xGQLQ5H6wJpxl6sE+BaRdZFNasQFNPPS9e0nExNeq8dk3qrw6NquAnvGg uZJ7YcaPRdfkMp0DX24/QVH/YoHdJ0kYYS0DJVGZdHALxo7ts+7ALpL7WLCldIF16EdK VnCfLuf2BFpWeYncX+EDuww9YVVzAk/1rS96+6B3qa+J967xNojJ3arNvl3VKfiIzqap kGJLhYQPYO/qrVkZTRg7sTxZ/pMhX1MJd6WLrlI7t8SPEvv41dMP9DqILZVDnxWkYBkx QQeYHX36eIPFbu+4/YvnUZAqPfkEmDLu1J4YV8bTAUaDvroFsoXaPZK8RxOSaebzi/OC C0vg== X-Gm-Message-State: ANoB5plE3n4f6Rb45b6Mo7kfbYpng5udgi6OryiXrCKu8F3GLe993xjL he3PzGgzRlbxoV1G6p0U4mo= X-Google-Smtp-Source: AA0mqf5P+SRv8U11ehbicMUj4i9ydMV/OoliorXkjUjPFrvL0pqcf1TRq4EOR92fDoYw0yryVsY7zQ== X-Received: by 2002:a17:90a:c702:b0:213:16b5:f45e with SMTP id o2-20020a17090ac70200b0021316b5f45emr14288978pjt.170.1668444999100; Mon, 14 Nov 2022 08:56:39 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id b16-20020a170902d51000b00186b9196cbesm7805421plg.249.2022.11.14.08.56.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 08:56:37 -0800 (PST) Message-ID: <07654cbf-50bf-c0d0-fd74-c434273a4e35@gmail.com> Date: Mon, 14 Nov 2022 09:56:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 4/7] riscv: Move riscv_block_move_loop to separate file Content-Language: en-US To: Christoph Muellner , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Vineet Gupta References: <20221113230521.712693-1-christoph.muellner@vrull.eu> <20221113230521.712693-5-christoph.muellner@vrull.eu> From: Jeff Law In-Reply-To: <20221113230521.712693-5-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/13/22 16:05, Christoph Muellner wrote: > From: Christoph Müllner > > Let's try to not accumulate too much functionality in one single file > as this does not really help maintaining or extending the code. > So in order to add more similar functionality like riscv_block_move_loop > let's move this function to a separate file. > > This change does not do any functional changes. > It does modify a single line in the existing code, > that check_GNU_style.py complained about. > > gcc/ChangeLog: > > * config.gcc: Add new object riscv-string.o > * config/riscv/riscv-protos.h (riscv_expand_block_move): Remove > duplicated prototype and move to new section for > riscv-string.cc. > * config/riscv/riscv.cc (riscv_block_move_straight): Remove function. > (riscv_adjust_block_mem): Likewise. > (riscv_block_move_loop): Likewise. > (riscv_expand_block_move): Likewise. > * config/riscv/riscv.md (cpymemsi): Move to new section for > riscv-string.cc. > * config/riscv/t-riscv: Add compile rule for riscv-string.o > * config/riscv/riscv-string.c: New file. OK.  Note I suspect the commit hooks are going to complain about your ChangeLog formatting. jeff