From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 229123858D39 for ; Mon, 14 Aug 2023 05:38:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 229123858D39 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1691991526; bh=ZmnWWIX8L1nVVLNXYb0OU6+M2Jf/ARXROy02p42fNyQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=mJ7mnhlg+vUJ91qg83KuSXY8KEat2seZaLoxpP0tvMPLE1y6w9rGBi4LE3iHMYi2m nVkMy0uHqCyalbdqJSLPR2Xqd/aIfpGo70lfyrZvNiHQBlgGpPA3DKBKi2H162bhzB Mhgo0kc4SW7bbJ3CpM0ZELEST7PH6gppMzsA80VY= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 0AC23659C0; Mon, 14 Aug 2023 01:38:44 -0400 (EDT) Message-ID: <07a023290a898ba3e7a6ae1c36e6e4562bc66aaf.camel@xry111.site> Subject: Re: [PATCH v1 1/6] LoongArch: a symmetric multilib subdir layout From: Xi Ruoyao To: Yang Yujie , gcc-patches@gcc.gnu.org Cc: xuchenghua@loongson.cn, panchenghui@loongson.cn, chenglulu@loongson.cn Date: Mon, 14 Aug 2023 13:38:40 +0800 In-Reply-To: <20230814035707.11272-1-yangyujie@loongson.cn> References: <20230814035707.11272-1-yangyujie@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-08-14 at 11:57 +0800, Yang Yujie wrote: > However, for LoongArch, we do not want such a "toplevel" library > installation since the default ABI may change. We expect all > multilib variants of libraries to be installed to their designated > ABI-specific subdirs (e.g. base/lp64d) of the GCC libdir, so that > the default ABI can be configured arbitrarily (with --with-abi) > while the gcc libdir layout stays consistent. This could be > helpful for the distribution packaging of GCC libraries. Have you tested a --disable-multilib configuration? To me with -- disable-configuration everything should be still in the toplevel directory, not any sub-directory. /* snip */ > ChangeLog: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * config-ml.in: add loongarch = support.=C2=A0 Allow overriding Use a tab, not 8 white spaces. Likewise for all patches in the series. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 toplevel multisubdir. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University