From: Jeff Law <law@redhat.com>
To: "Koval, Julia" <julia.koval@intel.com>,
Joseph Myers <joseph@codesourcery.com>
Cc: Jakub Jelinek <jakub@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] remove cilk-plus
Date: Mon, 27 Nov 2017 18:06:00 -0000 [thread overview]
Message-ID: <07db22a2-5c92-7eff-f0c0-e5952ce23c8c@redhat.com> (raw)
In-Reply-To: <4E89A029A0F8D443B436A5167BA3C53F42AD4D90@IRSMSX101.ger.corp.intel.com>
On 11/23/2017 02:45 AM, Koval, Julia wrote:
> Sorry, I think in this version of this patch they are fixed.
>
>> -----Original Message-----
>> From: Joseph Myers [mailto:joseph@codesourcery.com]
>> Sent: Wednesday, November 22, 2017 6:23 PM
>> To: Koval, Julia <julia.koval@intel.com>
>> Cc: Jeff Law <law@redhat.com>; Jakub Jelinek <jakub@redhat.com>; GCC
>> Patches <gcc-patches@gcc.gnu.org>
>> Subject: RE: [patch] remove cilk-plus
>>
>> This patch version does not appear to address my comment that you're
>> leaving behind comments in c-parser.c relating to Cilk array notations
>> while removing the subsequent code. (Or in one case actually reindenting
>> the comment that is no longer relevant, rather than removing it.)
>>
>> --
>> Joseph S. Myers
>> joseph@codesourcery.com
This version is fine to commit.
Can you also remove struct inv_list from c-family/c-common.h. It was
only used for array notation support. You can include that in your main
commit or as a separate follow-up.
We may well find other nits like inv_list. I'm comfortable addressing
those as we bump into them.
Thanks for taking care of this!
jeff
next prev parent reply other threads:[~2017-11-27 17:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 15:48 Koval, Julia
2017-11-16 15:49 ` Marek Polacek
2017-11-16 16:21 ` Jakub Jelinek
2017-11-16 17:06 ` Koval, Julia
2017-11-16 23:51 ` Joseph Myers
2017-11-21 7:46 ` Jeff Law
2017-11-22 8:47 ` Koval, Julia
2017-11-22 9:15 ` Rainer Orth
2017-11-22 9:22 ` Koval, Julia
2017-11-22 10:01 ` Koval, Julia
2017-11-22 17:33 ` Joseph Myers
2017-11-23 10:01 ` Koval, Julia
2017-11-27 18:06 ` Jeff Law [this message]
2017-11-30 11:55 ` Koval, Julia
2017-11-30 12:02 ` Jakub Jelinek
2017-11-30 16:40 ` Marek Polacek
2017-11-30 17:27 ` Jeff Law
2017-11-30 17:29 ` Jakub Jelinek
2017-11-23 17:58 ` Jeff Law
2017-11-16 16:34 ` Eric Gallager
2017-11-16 17:59 ` Jeff Law
2017-12-01 10:28 ` Paolo Carlini
2017-12-01 15:43 ` Jeff Law
2017-12-01 16:19 ` Paolo Carlini
2018-03-02 16:37 ` Thomas Schwinge
2018-03-02 16:43 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07db22a2-5c92-7eff-f0c0-e5952ce23c8c@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=julia.koval@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).