git commit hook does not record my patches to PRs

git commit hook does not record my patches to PRs

[Uros Bizjak]

Hello!

For some reason git commit hook does not record my patches to PRs,
mentioned in the commit message. Some recent examples:

PR 98521:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=951bdbde6ade56eb63af1dfa18777348a8a0d89e

and PR98522:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1ff0ddcd8b4728bcc96e1daf2e70a03dc9fbf171

These two patches were committed as a single push (but one commit per
push also doesn't reach the PR), and the second one is also missing in
the gcc-cvs mailing list archive:

https://gcc.gnu.org/pipermail/gcc-cvs/2021-January/date.html

In the commit message, I have put PR marks everywhere I can think of,
but the commit hook is still ignoring them. Can someone please check,
what is wrong with the flow and eventually advise me what to do to
enjoy the benefits of the automation.

Thanks,
Uros.

Re: git commit hook does not record my patches to PRs

[Jakub Jelinek]

On Tue, Jan 05, 2021 at 03:04:55PM +0100, Uros Bizjak via Gcc-patches wrote:
> Hello!
> 
> For some reason git commit hook does not record my patches to PRs,
> mentioned in the commit message. Some recent examples:

Maybe the python mess with UTF-8 is back.
> 
> PR 98521:
> https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=951bdbde6ade56eb63af1dfa18777348a8a0d89e
> 
> and PR98522:
> https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1ff0ddcd8b4728bcc96e1daf2e70a03dc9fbf171

	Jakub

Re: git commit hook does not record my patches to PRs

[Martin Liška]

On 1/5/21 3:04 PM, Uros Bizjak wrote:
> Hello!
> 
> For some reason git commit hook does not record my patches to PRs,
> mentioned in the commit message. Some recent examples:
> 
> PR 98521:
> https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=951bdbde6ade56eb63af1dfa18777348a8a0d89e
> 
> and PR98522:
> https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1ff0ddcd8b4728bcc96e1daf2e70a03dc9fbf171
> 
> These two patches were committed as a single push (but one commit per
> push also doesn't reach the PR), and the second one is also missing in
> the gcc-cvs mailing list archive:
> 
> https://gcc.gnu.org/pipermail/gcc-cvs/2021-January/date.html
> 
> In the commit message, I have put PR marks everywhere I can think of,
> but the commit hook is still ignoring them. Can someone please check,
> what is wrong with the flow and eventually advise me what to do to
> enjoy the benefits of the automation.

Hello.

I can reproduce that for gcc-reposurgeon-8 repository and yes, it's again related
to a unicode characters (in your case 'š' letter in your first name).

I'll debug that with Jakub.

Martin

> 
> Thanks,
> Uros.
> 

Re: git commit hook does not record my patches to PRs

[Martin Liška]

On 1/6/21 10:53 AM, Martin Liška wrote:
> I'll debug that with Jakub.

https://github.com/AdaCore/git-hooks/issues/18