From: Jeff Law <jeffreyalaw@gmail.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
"juzhe . zhong @ rivai . ai" <juzhe.zhong@rivai.ai>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] RISC-V: Add quotes to #error messages
Date: Mon, 21 Aug 2023 07:32:52 -0600 [thread overview]
Message-ID: <08872264-6819-4de9-b867-b85a084e64d1@gmail.com> (raw)
In-Reply-To: <6afb03099b118119ecca3dd8500e70ee9d523c6d.1692330726.git.research_trasio@irq.a4lg.com>
On 8/17/23 21:52, Tsukasa OI wrote:
> From: Tsukasa OI <research_trasio@irq.a4lg.com>
>
> In commit 1aaf3a64e92a ("[PATCH] RISC-V: Deduplicate #error messages in
> testsuite"), the author made a mistake to miss the test after adding
> quotes around extension names. To avoid future errors and for consistency
> with other #error uses in the RISC-V testsuite, this commit quotes #error
> messages where necessary to avoid current test case failures.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/zvkn.c: Quote #error messages.
> * gcc.target/riscv/zvkn-1.c: Ditto.
> * gcc.target/riscv/zvknc.c: Ditto.
> * gcc.target/riscv/zvknc-1.c: Ditto.
> * gcc.target/riscv/zvknc-2.c: Ditto.
> * gcc.target/riscv/zvkng.c: Ditto.
> * gcc.target/riscv/zvkng-1.c: Ditto.
> * gcc.target/riscv/zvkng-2.c: Ditto.
> * gcc.target/riscv/zvks.c: Ditto.
> * gcc.target/riscv/zvks-1.c: Ditto.
> * gcc.target/riscv/zvksc.c: Ditto.
> * gcc.target/riscv/zvksc-1.c: Ditto.
> * gcc.target/riscv/zvksc-2.c: Ditto.
> * gcc.target/riscv/zvksg.c: Ditto.
> * gcc.target/riscv/zvksg-1.c: Ditto.
> * gcc.target/riscv/zvksg-2.c: Ditto.
Thanks. I've pushed both patches in this series to the trunk.
jeff
next prev parent reply other threads:[~2023-08-21 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 2:53 [PATCH] RISC-V: Deduplicate #error messages in testsuite Tsukasa OI
2023-08-17 13:53 ` Jeff Law
2023-08-18 3:52 ` [PATCH 1/2] RISC-V: Add quotes to #error messages Tsukasa OI
2023-08-21 13:32 ` Jeff Law [this message]
2023-08-18 3:52 ` [PATCH 2/2] RISC-V: Add quotes to #error messages (all) Tsukasa OI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08872264-6819-4de9-b867-b85a084e64d1@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).