public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: davidxl@google.com
To: xur@google.com
Cc: gcc-patches@gcc.gnu.org, reply@codereview-hr.appspotmail.com
Subject: Re: [google 4.7] fdo build for linux kernel (issue 6968046)
Date: Thu, 20 Dec 2012 01:04:00 -0000	[thread overview]
Message-ID: <089e013a2ef42aa48e04d13e51e6@google.com> (raw)

The change in gcov-io.h is from a different patch.

David


https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c
File gcc/gcov-io.c (right):

https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c#newcode688
gcc/gcov-io.c:688:
Have you compared this with this impl:

while (x)
{
    c++;
    x&=(x-1)
}
return c;

https://codereview.appspot.com/6968046/

             reply	other threads:[~2012-12-20  1:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20  1:04 davidxl [this message]
2012-12-20  1:22 ` Rong Xu
2012-12-20 19:30   ` Rong Xu
2012-12-20 19:55     ` Xinliang David Li
2012-12-20 22:01       ` Rong Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=089e013a2ef42aa48e04d13e51e6@google.com \
    --to=davidxl@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=reply@codereview-hr.appspotmail.com \
    --cc=xur@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).