From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6080 invoked by alias); 26 Jul 2016 04:25:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6053 invoked by uid 89); 26 Jul 2016 04:25:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 26 Jul 2016 04:25:05 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54875883A2; Tue, 26 Jul 2016 04:25:03 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-144.phx2.redhat.com [10.3.116.144]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6Q4P2VF025080; Tue, 26 Jul 2016 00:25:03 -0400 Subject: Re: [PATCH 2/3] Run profile feedback tests with autofdo To: Andi Kleen , =?UTF-8?Q?Martin_Li=c5=a1ka?= References: <20160623143719.17603-1-andi@firstfloor.org> <20160623143719.17603-2-andi@firstfloor.org> <20160623143719.17603-3-andi@firstfloor.org> <20160714105512.GE5871@two.firstfloor.org> <20160714223341.GG5871@two.firstfloor.org> <13e22c8f-2be6-3087-54c0-8a945b5d3768@suse.cz> <20160726042111.GQ5871@two.firstfloor.org> Cc: "Bin.Cheng" , gcc-patches List From: Jeff Law Message-ID: <08ae1389-5df2-442a-ce6b-1ffe3922def5@redhat.com> Date: Tue, 26 Jul 2016 04:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160726042111.GQ5871@two.firstfloor.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg01682.txt.bz2 On 07/25/2016 10:21 PM, Andi Kleen wrote: > On Mon, Jul 25, 2016 at 01:08:43PM +0200, Martin Liška wrote: >> On 07/15/2016 10:37 AM, Bin.Cheng wrote: >>> On Thu, Jul 14, 2016 at 11:33 PM, Andi Kleen wrote: >>>>>>> I haven't seen that. Unstable in what way? >>>>>> For GCC doesn't support FDO, it run below tests as you said: >>>>>> >>>>>> PASS: gcc.dg/tree-prof/20041218-1.c compilation, -g >>>>>> UNSUPPORTED: gcc.dg/tree-prof/20041218-1.c: Cannot run create_gcov >>>>>> --binary /data/work/trunk/build/gcc/testsuite/gcc/20041218-1.gcda >>>>>> >>>>>> Normally, it doesn't create gcov data file, thus the next test is >>>>>> unsupported. I guess in parallel test, the second test picks up gcov >>>>>> data files from other process, which results in random pass. >>>>>> Is it possible to not have these when fdo is supported? >>>>> Hmm, typo: s/supported/not supported/. >>>> >>>> I don't see how this can happen: as you can see the .gcda file name >>>> is unique for each test case. >>>> >>>> I think there may be problems with the perf.data, could add a postfix. >>>> But you should only see that with real autofdo. >>> Don't know. I only configured/built GCC on x86_64 with below command lines: >>> >>> $ ../gcc/configure --prefix=... >>> --enable-languages=c,c++,fortran,go,java,lto,objc,obj-c++ >>> --with-build-config=bootstrap-O3 --disable-werror >>> $ make && make install >>> >>> Not sure what the status for autofdo is in this case. "make check -k" >>> is stable for me, but "make check -k -j#" gives unstable result in >>> tree-prof.exp tests. Anything I did wrong? >>> >>> Thanks, >>> bin >>> >> >> I can confirm that I see the same problem on a Xeon machine (../configure && make && make check -k -jX). >> I see many: >> >> g++.dg/tree-prof/pr35545.C: Cannot run create_gcov --binary /home/marxin/Programming/gcc/objdir/gcc/testsuite/g++/pr35545.x01 --profile=perf.data -gcov_version=1 --gcov=/home/marxin/Programming/gcc/objdir/gcc/testsuite/g++/pr35545.gcda > > Well that's expected if you don't have autofdo installed or perf with > lbrs is not working. The test case will be UNSUP in this case. > > But it's not expected that it is not deterministic, so that it changes > run to run. Do you see that? Or some other problem? Please describe > it exactly. It definitely changes run to run for me. Jeff