Re: [PATCH] gcc.misc-tests/outputs.exp: assert unique test-names

[Jeff Law <jeffreyalaw@gmail.com>]

On 2/24/21 10:17 PM, Hans-Peter Nilsson via Gcc-patches wrote:
> The gcc.misc-tests/outputs.exp tests can take some effort to
> digest.
>
> Navigating and debugging causes for failing tests here isn't
> helped by the existence of tests with duplicate names.
> Let's stop that from happening.  This requires that test-run
> output is actually reviewed, as Tcl errors don't stop the
> test-run, but then again there's no such dejagnu construct
> that I know of.
>
> Tested x86_64-pc-linux-gnu.
>
> Ok to commit?  Or is a renaming patch appending a
> number-suffix, like:
>
> --- outputs.exp.orig3	2021-02-25 06:13:28.304243791 +0100
> +++ outputs.exp	2021-02-25 06:13:51.575457825 +0100
> @@ -280,8 +280,8 @@ if { "$aout" != "" } then {
>  }
>  
>  # Driver-chosen outputs.
> -outest "$b asm default 1" $sing "-S" {} {{-0.s}}
> -outest "$b asm default 2" $mult "-S" {} {{-1.s -2.s}}
> +outest "$b-1 asm default 1" $sing "-S" {} {{-0.s}}
> +outest "$b-2 asm default 2" $mult "-S" {} {{-1.s -2.s}}
> ...
>
> ...better and ok to commit?  (IMHO: yes, much easier to follow)
>
> gcc/testsuite:
> 	* gcc.misc-tests/outputs.exp: Append discriminating
> 	suffixes to tests with duplicate names.
> 	(outest): Assert that each running test has a unique
> 	name.
OK.  And I think that in general changes which fix duplicated testnames
should be considered as not needing approval.  Just fix 'em and post the
patch for the historical record :-)

jeff