From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Bill Schmidt <wschmidt@linux.ibm.com>,
richard.sandiford@arm.com
Subject: Re: [RFC/PATCH] vect: Recog mul_highpart pattern
Date: Thu, 15 Jul 2021 09:40:52 +0800 [thread overview]
Message-ID: <08efc2b2-dd61-1c15-df14-ebfcede2c664@linux.ibm.com> (raw)
In-Reply-To: <20210714193246.GB1583@gate.crashing.org>
on 2021/7/15 上午3:32, Segher Boessenkool wrote:
> On Wed, Jul 14, 2021 at 12:32:24PM +0100, Richard Sandiford wrote:
>> TBH, 79 vs. 80 isn't normally something I'd worry about when reviewing
>> new code. But I know in the past people have asked for 79 to be used
>> for the “end+1” reason, so I don't think we should “fix” existing code
>> that honours the 79 limit so that it no longer does, especially when the
>> lines surrounding the code aren't changing.
>
> The normal rule is you cannot go over 80. It is perfectly fine to have
> shorter lines, certainly if that is nice for some other reason, so
> automatically (by some tool) changing this is Just Wrong.
>
OK, could this be applied to changelog entry too? I guess yes?
BR,
Kewen
next prev parent reply other threads:[~2021-07-15 1:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 8:52 Kewen.Lin
2021-07-13 8:58 ` [PATCH] rs6000: Support [u]mul<mode>3_highpart for vector Kewen.Lin
2021-07-13 22:07 ` Segher Boessenkool
2021-07-14 2:12 ` Kewen.Lin
2021-07-14 18:38 ` Segher Boessenkool
2021-07-13 9:35 ` [RFC/PATCH] vect: Recog mul_highpart pattern Richard Biener
2021-07-13 9:40 ` Richard Sandiford
2021-07-13 9:44 ` Richard Biener
2021-07-13 10:11 ` Richard Sandiford
2021-07-13 10:25 ` Kewen.Lin
2021-07-13 12:42 ` Richard Biener
2021-07-13 14:59 ` Kewen.Lin
2021-07-14 6:38 ` Richard Biener
2021-07-14 7:45 ` Kewen.Lin
2021-07-14 8:38 ` Richard Sandiford
2021-07-14 10:02 ` Kewen.Lin
2021-07-14 11:32 ` Richard Sandiford
2021-07-14 19:32 ` Segher Boessenkool
2021-07-15 1:40 ` Kewen.Lin [this message]
2021-07-15 23:08 ` Segher Boessenkool
2021-07-15 1:37 ` Kewen.Lin
2021-07-15 7:06 ` [PATCH v3] " Kewen.Lin
2021-07-15 7:17 ` Uros Bizjak
2021-07-15 8:04 ` Kewen.Lin
2021-07-15 8:23 ` Uros Bizjak
2021-07-15 8:49 ` Kewen.Lin
2021-07-15 9:41 ` Uros Bizjak
2021-07-15 8:40 ` Kewen.Lin
2021-07-15 11:58 ` Richard Biener
2021-07-16 5:33 ` [PATCH v4] " Kewen.Lin
2021-07-19 10:35 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08efc2b2-dd61-1c15-df14-ebfcede2c664@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).