Re: Ping: Re: [PATCH] libgcc: fix SEH C++ rethrow semantics [PR113337]

[Matteo Italia <matteo@mitalia.net>]

Il 06/02/24 10:17, Jonathan Yong ha scritto:
> On 2/6/24 05:31, NightStrike wrote:
>> On Mon, Feb 5, 2024, 06:53 Matteo Italia <matteo@mitalia.net> wrote:
>>
>>> Il 31/01/24 04:24, LIU Hao ha scritto:
>>>> 在 2024-01-31 08:08, Jonathan Yong 写道:
>>>>> On 1/24/24 15:17, Matteo Italia wrote:
>>>>>> Ping! That's a one-line fix, and you can find all the details in the
>>>>>> bugzilla entry. Also, I can provide executables built with the
>>>>>> affected toolchains, demonstrating the problem and the fix.
>>>>>>
>>>>>> Thanks,
>>>>>> Matteo
>>>>>>
>>>>>
>>>>> I was away last week. LH, care to comment? Changes look fine to me.
>>>>>
>>>>
>>>> The change looks good to me, too.
>>>>
>>>> I haven't tested it though. According to a similar construction around
>>>> 'libgcc/unwind.inc:265' it should be that way.
>>>
>>> Hello,
>>>
>>> thank you for the replies, is there anything else I can do to help push
>>> this forward?
>>>
>>
>> Remember to mention the pr with the right syntax in the ChangeLog so the
>> bot adds a comment field. I didn't see it in yours, but I might have 
>> missed
>> it.
>>
>>>
>>
>
> Thanks all, pushed to master branch.

Thanks all :-) do you think this warrants backports? On one hand this is 
a pretty niche feature, and I am probably the first to notice the 
problem in ~12 years since that code was written, OTOH Win64/SEH was not 
super widespread for a long time, and seems like a safe enough change.

Also: should I explicitly mark PR113337 as resolved? The bot added the 
reference to the commit, but the PR is still marked as "UNCONFIRMED".