From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hostingweb35-23.netsons.net (hostingweb35-23.netsons.net [89.40.175.23]) by sourceware.org (Postfix) with ESMTPS id 290563858C53 for ; Wed, 7 Feb 2024 09:23:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 290563858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=mitalia.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mitalia.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 290563858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.40.175.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707297783; cv=none; b=nf+eyWW8XgsLjdLIS2eTwyrcLBrDhV90eripO/6cTjWGqZKeY82IxLR6CjD7wDB9EAdmOIDGOzO69lWiBNvTO1x4pVr8b9VJcrcPsI+pqjyeQro9yOi8rckyqTonpuZTmnZxDrZ4gGxnh65+IphJHNUFWifZviJT50Jmy7QiU8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707297783; c=relaxed/simple; bh=psoPCwMILtYjTalxF2mPKrZTaMF8YK7+bLrqZx1jx5M=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dKu2Hlw3L1mAmBoMvclcB5SDYZ2sfMxTPr57EGYIZd99EqxUMj1jVYtW1vm+wJGeXzmvxav+e9PliOnjo+Y5pDS6zR/3oyAXzKeBLiWop+fqQWiibwkLhiFDwNtmr+Y14x4HZn/lVQaqAjOpNbO01uzVw+gVMcTzTznFK0PVZH4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mitalia.net ; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sVp+KgEoJP+XTT7Q1KNAPbyQeYsPBf3vl8wUFmcvxSg=; b=sJxCScQsCiHTm29x8n/yUDa+8w RZdKXoCT7pM5WOxd2AJB+lZMQ9RqUAY+TqyrU6Mu+mJbDLRHapCZ3psH2aKS8Lm66RlYu6Gcyxn6o r2pJE2YxteZCyXH3IXxAklc6FZmsGZIa+/1QnoBRBWTefZ48c5V7pQDOAkNcsHYfnwgU=; Received: from [81.56.101.54] (port=30603 helo=[192.168.1.140]) by hostingweb35.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1rXe8x-00Cz12-2F; Wed, 07 Feb 2024 10:22:59 +0100 Message-ID: <09006431-9e72-4573-98a5-123584c8526f@mitalia.net> Date: Wed, 7 Feb 2024 10:22:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Ping: Re: [PATCH] libgcc: fix SEH C++ rethrow semantics [PR113337] To: Jonathan Yong <10walls@gmail.com>, NightStrike Cc: LIU Hao , GCC Patches , tristan.gingold@cern.ch References: <20240117115144.50181-1-matteo@mitalia.net> <6e99ca24-96b1-400b-8df7-3329b71b7dbc@mitalia.net> <5ae51fe8-3e30-4535-b272-e540bf62ab3a@126.com> <413f8fb6-6af3-48ab-9a9b-33e3ac9d46f7@mitalia.net> <82b90a96-99ce-4e9e-b4cc-11166b700327@gmail.com> Content-Language: en-US From: Matteo Italia Autocrypt: addr=matteo@mitalia.net; keydata= xsBNBE781nMBCADTHv2VUZpN5Vzt82wLoFfy6qLKaO2hI3uxMyMTX4c+yKZcgS0XHwRA4mH3 Y6FL8TgMlool4pyfPEfbNutsV+Qgqq3If+b1WcKsk8Tx4++ovZ7puEVQoTUVbm68uqkeO7yT XaKOrqxFHXkjPiD2/V4mNhbCqg/74erW3ca1x8in6632+bHWxNm7mcwQOHheD/X14ZX51FbC HsIJNt1ccpB3ubiU16+fKjEXuSncPlqZSvqsiCWnvxxRGjkrH+jHjlVMw5JhO4mjvR1kcm5W 7aLxjgrEYcZkcAsHBUPdrke8gxOy5+zPrGD5q9AohrdyCXgN+jZ/ML5x3jh8zEOYI/RBABEB AAHNNk1hdHRlbyBJdGFsaWEgKExhdW5jaFBhZCBQR1AgS2V5KSA8bWF0dGVvQG1pdGFsaWEu bmV0PsLAeAQTAQIAIgUCTvzWcwIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQsqqf swcN9CjXAggAtntm+pEv4vypUuGianqI01EX6xhm3i68DEAa8G7jPqyEZgL0zUJEaQB5Vfkf /dqC3vUxp5+HlEJ4fBYLVUvmnKH5A10cRbgQQkik+OjhoXD+omsBqGyfyzageN7X8/SCTqZo WaPK1uUE24W3KjJsP8Hr7kHOg0SHaCSGnnoQTvsWoLH9QT1b1sM8LA10OZShgFIVSIa7rK+s 78PzqdJWJAlHVHVIfp5leY4sMtb+gSRK/I4jCwSoPo1Uw9nNXghEBls03XC6Wkseh4JxFHmi aGFnQ8pWFkHQZ3ubhBlFyPnDr3CdFTGOgS3aXhD+zXvWotXT3ouHoHB8CONMVIaQPs7ATQRO /NZzAQgAzWlzUa+p3HcYH/h8w8uPoqwQ6+D47PVRxDLPyZ8ePHq365CTEFEbzXSjG6tVkHJS pdYlu4CwxGX/t4A1k8aRijG+4LCNyB8CMvoN7THW+Z/yF9klP9Qmademhz2IFjqGhyWZ+KBW OV6G/I8Yf2i/ROYKATwF5Qmf6CJUtzqNQiqjiun153Vz6JKUSiPCTw/f+NcmalqPW0aqKWtK +cuQgB4Ubtfr8DoP5JQZfXHOom0L/rNJvZq/r1gYKuAInaku6o/UaMwyMeHR29uatm8PbgKL zj9uABBBDifi9pwkUepBBCuSEKUk5fgXuS/t2tA2dXShbNH2PoBdAWa3A2+wvQARAQABwsBe BBgBAgAJBQJO/NZzAhsMAAoJELKqn7MHDfQoZJwH90zf5+D2foI6s/7kzxsOPRUUXLgyp+wn m1qq9AqWduHvtCyQMghglelzGuZIvbPmBBcucfENIOQXuVyWWtHML4RnWks7Q1hcEpBwIstH dq5MKA5N1Eqt3PI2duU68Fpd4J3QNljCPee1uD3qrAVTgvfFsd1CuMNf6MPx4oHU3hK5Wez4 A0KLrffpGVUAeblOKG934g3zkbyqDfNQsvq7fP8AUop+mxh+GN6gf5pgom1K/VIFDK1iwsq4 Hyh6qm3POE0loKiKF8lQg3bnNV656Dq1d3mAymu5qrH6G7Au1WefodxHnkykMrlYKtL7AELI hxsnb9H/hoDOk9WuXLXM/g== In-Reply-To: <82b90a96-99ce-4e9e-b4cc-11166b700327@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb35.netsons.net X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - mitalia.net X-Get-Message-Sender-Via: hostingweb35.netsons.net: authenticated_id: matteo@mitalia.net X-Authenticated-Sender: hostingweb35.netsons.net: matteo@mitalia.net X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Il 06/02/24 10:17, Jonathan Yong ha scritto: > On 2/6/24 05:31, NightStrike wrote: >> On Mon, Feb 5, 2024, 06:53 Matteo Italia wrote: >> >>> Il 31/01/24 04:24, LIU Hao ha scritto: >>>> 在 2024-01-31 08:08, Jonathan Yong 写道: >>>>> On 1/24/24 15:17, Matteo Italia wrote: >>>>>> Ping! That's a one-line fix, and you can find all the details in the >>>>>> bugzilla entry. Also, I can provide executables built with the >>>>>> affected toolchains, demonstrating the problem and the fix. >>>>>> >>>>>> Thanks, >>>>>> Matteo >>>>>> >>>>> >>>>> I was away last week. LH, care to comment? Changes look fine to me. >>>>> >>>> >>>> The change looks good to me, too. >>>> >>>> I haven't tested it though. According to a similar construction around >>>> 'libgcc/unwind.inc:265' it should be that way. >>> >>> Hello, >>> >>> thank you for the replies, is there anything else I can do to help push >>> this forward? >>> >> >> Remember to mention the pr with the right syntax in the ChangeLog so the >> bot adds a comment field. I didn't see it in yours, but I might have >> missed >> it. >> >>> >> > > Thanks all, pushed to master branch. Thanks all :-) do you think this warrants backports? On one hand this is a pretty niche feature, and I am probably the first to notice the problem in ~12 years since that code was written, OTOH Win64/SEH was not super widespread for a long time, and seems like a safe enough change. Also: should I explicitly mark PR113337 as resolved? The bot added the reference to the commit, but the PR is still marked as "UNCONFIRMED".