From: Jeff Law <law@redhat.com>
To: Mihailo Stojanovic <mihailo.stojanovic@rt-rk.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [MIPS] Remove unnecessary moves around DSP multiply-accumulate instructions
Date: Wed, 12 Feb 2020 21:41:00 -0000 [thread overview]
Message-ID: <095b19ed7eb872ff826658af0e4e83dfb6ed07b0.camel@redhat.com> (raw)
In-Reply-To: <1580994301-24481-1-git-send-email-mihailo.stojanovic@rt-rk.com>
On Thu, 2020-02-06 at 14:05 +0100, Mihailo Stojanovic wrote:
> Unnecessary moves around dpadd and dpsub are caused by different pseudos
> being assigned to the input-output operands which correspond to the same
> register.
>
> Just like for the MSA multiply-accumulate instructions, this forces the
> same pseudo to the input-output operands,
> which removes unnecesary moves.
>
> Tested on mips-mti-linux-gnu.
>
> gcc/ChangeLog:
>
> * gcc/config/mips/mips.c (mips_expand_builtin_insn): Operands of
> DSP multiply-accumulate instructions which correspond to the
> same input-output register now have the same pseudo asigned to
> them.
>
> gcc/testsuite/ChangeLog:
>
> * gcc/testsuite/gcc.target/mips/mac-zero-reload.c: New test.
Affects just MIPS, so OK even though we're in stage4.
jeff
>
prev parent reply other threads:[~2020-02-12 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 13:05 Mihailo Stojanovic
2020-02-12 21:41 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=095b19ed7eb872ff826658af0e4e83dfb6ed07b0.camel@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mihailo.stojanovic@rt-rk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).