From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25633 invoked by alias); 16 Sep 2016 17:00:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25619 invoked by uid 89); 16 Sep 2016 17:00:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_MANYTO,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=exceeding X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Sep 2016 17:00:53 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C216ADF150; Fri, 16 Sep 2016 17:00:51 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-2.phx2.redhat.com [10.3.116.2]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8GH0nYk018992; Fri, 16 Sep 2016 13:00:50 -0400 Subject: Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905) To: Martin Sebor , Richard Biener , Gcc Patch List , Jakub Jelinek , Bernd Schmidt , David Malcolm , =?UTF-8?B?TWFudWVsIEzDs3Blei1JYsOhw7Fleg==?= , Florian Weimer , Joseph Myers References: <5776B33E.2080504@gmail.com> <577A8D6A.3070902@gmail.com> <578D512F.9050909@gmail.com> <9bb5ad66-4985-8c42-f800-4d84e0e18659@redhat.com> <57A3AFFF.7090109@gmail.com> <57AD30E5.3000801@gmail.com> <22a47656-c23c-4840-2e49-a59f4af513b1@redhat.com> <57B725F6.8000405@gmail.com> <110cfc6b-7856-9b51-885f-05402b14fc3e@redhat.com> <57D1B5F0.1030504@gmail.com> From: Jeff Law Message-ID: <0965f4ef-c2bc-ad19-52ab-4b33ed544484@redhat.com> Date: Fri, 16 Sep 2016 17:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57D1B5F0.1030504@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg01067.txt.bz2 On 09/08/2016 01:03 PM, Martin Sebor wrote: > Attached is another update to the patch to address the last round > of comments and suggestions, most notably to: > > * implement the checking of the implementation limit of 4,095 on > the output of a single directive to allow for the Glibc failure > due to ENOMEM (the patch issues a warning and disables the > optimization when this happens) > * implement checking for exceeding INT_MAX bytes (warn and disable > optimization) > * call set_range_info when the return value optimization is not > possible > * remove code to work around tree-optimization/71831 (now on > trunk) > > The -fprintf-return value optimization is still disabled. GCC > successfully bootstraps with it and most tests pass but there's > a failure in the Fortran libgomp tests that I am yet to figure > out. I'm just now getting back to this (sorry for the long delay). I see there's another version after this one. Did the version from 9/11/2016 address the Fortran libgomp test issue? jeff