From: David Malcolm <dmalcolm@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c/c++: new warning: -Wxor-used-as-pow [PR90885]
Date: Fri, 02 Sep 2022 18:39:36 -0400 [thread overview]
Message-ID: <0974b0223c2f89d2084a0827b3112e8efd636f0b.camel@redhat.com> (raw)
In-Reply-To: <Yw51yyzNoASv3uX9@redhat.com>
On Tue, 2022-08-30 at 16:40 -0400, Marek Polacek wrote:
> This looks good to me, one thing though:
>
> On Thu, Aug 11, 2022 at 09:38:12PM -0400, David Malcolm via Gcc-
> patches wrote:
> > --- a/gcc/c-family/c.opt
> > +++ b/gcc/c-family/c.opt
> > @@ -1439,6 +1439,10 @@ Wwrite-strings
> > C ObjC C++ ObjC++ Var(warn_write_strings) Warning
> > In C++, nonzero means warn about deprecated conversion from string
> > literals to 'char *'. In C, similar warning, except that the
> > conversion is of course not deprecated by the ISO C standard.
> >
> > +Wxor-used-as-pow
> > +C C++ Common Var(warn_xor_used_as_pow) Warning Init(1)
>
> This doesn't include ObjC/ObjC++, but...
I added ObjC/ObjC++ (and dropped Common), and retested it (and tested
it with -xobjective-c and -xobjective-c++); I've pushed it to trunk as
r13-2386-gbedfca647a9e9c.
Thanks
Dave
prev parent reply other threads:[~2022-09-02 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 1:38 David Malcolm
2022-08-30 20:18 ` Jason Merrill
2022-08-30 20:40 ` Marek Polacek
2022-09-02 22:39 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0974b0223c2f89d2084a0827b3112e8efd636f0b.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).