From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id D14263858D39 for ; Wed, 6 Jul 2022 13:14:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D14263858D39 Received: by mail-pl1-x634.google.com with SMTP id d5so13580539plo.12 for ; Wed, 06 Jul 2022 06:14:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=BZuTlXgaS/gppijZ+7n04LP5g6lTm+ZAhIhGAVocJ3A=; b=yv1GoJMtuJqloYnUjn/YBFnAQhEvEXaBiDKyI38l1c554DS9fRaAy/2ayYi4SKiNBW Khufo9gOGfHWXKj+SFFOLII9XpoL0nth5k9tQpzZFc1cGElUaz1JMNISXhml6znHA1PV CiclGotB7M/Eag4oMbHS7myZlPdC97lztCe+7U22lDaDcLu6rgc1oWSQwheF6ryvow1H dTd3aG7W1fleOB9O3wc7bkFmaCG/xD4iLXBrkBil385zu7GRynJOFvscOt+M2C6yG4ZD J0oSu5sFpHzWd9pMjw+SQCRgC3EDBsjXqSakeFrfRz8AaQ6FZ++cru/XVnQrAChq9VLe KwXw== X-Gm-Message-State: AJIora+jOEg64LlmLUqVyWpFy7R3wdamd+be9mJSjMGG1XM7fQQniyf9 2ZdxrHucQqqMULH59FRmuBjROf0LCdc= X-Google-Smtp-Source: AGRyM1vhZymPE1hnrmImceNVpeNn2FeezwMf8kU2DyDEgwP434jXioYb7h6YtvhwEmWAHsZdBIQWUg== X-Received: by 2002:a17:90b:4a03:b0:1ed:2071:e8c with SMTP id kk3-20020a17090b4a0300b001ed20710e8cmr51907932pjb.216.1657113248524; Wed, 06 Jul 2022 06:14:08 -0700 (PDT) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id x67-20020a628646000000b005252ab25363sm24866082pfd.206.2022.07.06.06.14.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 06:14:08 -0700 (PDT) Message-ID: <0982e946-e953-45e2-ab1b-1d73537addf2@gmail.com> Date: Wed, 6 Jul 2022 07:14:06 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH]middle-end: don't lower past veclower [PR106063] Content-Language: en-US To: gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 13:14:12 -0000 On 7/5/2022 9:00 AM, Tamar Christina via Gcc-patches wrote: > Hi All, > > My previous patch can cause a problem if the pattern matches after veclower > as it may replace the construct with a vector sequence which the target may not > directly support. > > As such don't perform the rewriting if after veclower. > > Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu > and no issues. > > Ok for master? and backport to GCC 12? > > Thanks, > Tamar > > > gcc/ChangeLog: > > PR tree-optimization/106063 > * match.pd: Do not apply pattern after veclower. > > gcc/testsuite/ChangeLog: > > PR tree-optimization/106063 > * gcc.dg/pr106063.c: New test. OK for both the trunk and gcc-12. jeff