From: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
To: Joern Wolfgang Rennecke <gnu@amylaar.uk>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "Francois.Bedard@synopsys.com" <Francois.Bedard@synopsys.com>,
"jeremy.bennett@embecosm.com" <jeremy.bennett@embecosm.com>
Subject: RE: [PATCH 0/2] [ARC] Small fixes
Date: Mon, 25 Jan 2016 14:56:00 -0000 [thread overview]
Message-ID: <098ECE41A0A6114BB2A07F1EC238DE896616E0F3@de02wembxa.internal.synopsys.com> (raw)
In-Reply-To: <56A635E1.80504@amylaar.uk>
> FWIW, there's probably a missed optimization here - these constant -
> constant comparisons could be folded down further.
They are. The issue is when the CSE runs, wants to validate a new instruction with the propagated constant, which will lead to errors as it checks the proper_comaprison_operator, as it hits the assert at the end. Returning zero, it invalidates the instruction change, and the constant comparison will be handled later on by other steps.
//Claudiu
prev parent reply other threads:[~2016-01-25 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 13:34 Claudiu Zissulescu
2016-01-25 13:34 ` [PATCH 1/2] [ARC] Fix arcset* pattern's predicate Claudiu Zissulescu
2016-01-25 13:34 ` [PATCH 2/2] [ARC] Reject constant-constant comparison Claudiu Zissulescu
2016-01-25 14:49 ` [PATCH 0/2] [ARC] Small fixes Joern Wolfgang Rennecke
2016-01-25 14:56 ` Claudiu Zissulescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=098ECE41A0A6114BB2A07F1EC238DE896616E0F3@de02wembxa.internal.synopsys.com \
--to=claudiu.zissulescu@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu@amylaar.uk \
--cc=jeremy.bennett@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).