public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	"Francois.Bedard@synopsys.com" <Francois.Bedard@synopsys.com>
Subject: RE: [PATCH 4/7] [ARC] [LRA] Avoid emitting COND_EXEC during expand.
Date: Thu, 13 Jul 2017 12:54:00 -0000	[thread overview]
Message-ID: <098ECE41A0A6114BB2A07F1EC238DE8966630159@de02wembxa.internal.synopsys.com> (raw)
In-Reply-To: <20170713113819.GD27353@embecosm.com>

> This seems fine, your description "....does not always work." is a bit
> of a tease :) it would be nice to know _why_ it doesn't work, or at
> least a description of what problem you're seeing.
> 
As far as I can see, LRA doesn't handle very well the conditional execution patterns, as it expects conditional execution to happen after this step. Thus, some of those instructions are marked dead and removed later on.

> Also we seem to be missing a test, would it be possible to find one?
> If not then I guess we live without, but we should note that in the
> commit message.

This error is found by executing dg.exp testsuite with our port and -mlra option on.  As we speak, I am on the last 100m of testing our port having the LRA on. This bug being found like that.

I'll add this discussion to the commit message body.

Thank you,
Claudiu

  reply	other threads:[~2017-07-13 12:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 13:37 [PATCH 0/7] [ARC] Bug fixing, add support for naked functions Claudiu Zissulescu
2017-06-01 13:37 ` [PATCH 4/7] [ARC] [LRA] Avoid emitting COND_EXEC during expand Claudiu Zissulescu
2017-07-13 11:38   ` Andrew Burgess
2017-07-13 12:54     ` Claudiu Zissulescu [this message]
2017-07-17 13:02     ` Claudiu Zissulescu
2017-06-01 13:37 ` [PATCH 3/7] [ARC] [LRA] Fix tests asm constraints Claudiu Zissulescu
2017-06-16 19:37   ` Andrew Burgess
2017-07-10 13:56     ` Claudiu Zissulescu
2017-06-01 13:37 ` [PATCH 2/7] [ARC] Define ADDITIONAL_REGISTER_NAMES Claudiu Zissulescu
2017-06-16 19:37   ` Andrew Burgess
2017-07-10 13:57     ` Claudiu Zissulescu
2017-06-01 13:38 ` [PATCH 7/7] [ARC] Consolidate PIC implementation Claudiu Zissulescu
2017-07-13 13:31   ` Andrew Burgess
2017-07-17 11:05     ` Claudiu Zissulescu
2017-06-01 13:38 ` [PATCH 5/7] [ARC] Enable indexed loads for elf targers Claudiu Zissulescu
2017-07-13 11:55   ` Andrew Burgess
2017-07-13 13:08     ` Claudiu Zissulescu
2017-07-17 12:33     ` Claudiu Zissulescu
2017-06-01 13:38 ` [PATCH 6/7] [ARC] Deprecate mexpand-adddi option Claudiu Zissulescu
2017-07-13 13:18   ` Andrew Burgess
2017-07-13 13:31     ` Claudiu Zissulescu
2017-07-17 13:01     ` Claudiu Zissulescu
2017-06-01 13:38 ` [PATCH 1/7] [ARC] Add support for naked functions Claudiu Zissulescu
2017-06-16 19:36   ` Andrew Burgess
2017-06-19  9:55     ` [PATCH][ARC] " Claudiu Zissulescu
2017-07-13 11:21       ` Andrew Burgess
2017-07-17 10:47         ` Claudiu Zissulescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=098ECE41A0A6114BB2A07F1EC238DE8966630159@de02wembxa.internal.synopsys.com \
    --to=claudiu.zissulescu@synopsys.com \
    --cc=Francois.Bedard@synopsys.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).