From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57356 invoked by alias); 23 Apr 2018 09:57:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 57339 invoked by uid 89); 23 Apr 2018 09:57:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=ww, 48, sk:registe X-HELO: smtprelay.synopsys.com Received: from smtprelay.synopsys.com (HELO smtprelay.synopsys.com) (198.182.47.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Apr 2018 09:57:12 +0000 Received: from mailhost.synopsys.com (mailhost3.synopsys.com [10.12.238.238]) by smtprelay.synopsys.com (Postfix) with ESMTP id 0140524E0B09; Mon, 23 Apr 2018 02:57:10 -0700 (PDT) Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2-vip.internal.synopsys.com [10.12.239.238]) by mailhost.synopsys.com (Postfix) with ESMTP id 7C27B33FE; Mon, 23 Apr 2018 02:57:10 -0700 (PDT) Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by US01WEHTC2.internal.synopsys.com (10.12.239.237) with Microsoft SMTP Server (TLS) id 14.3.361.1; Mon, 23 Apr 2018 02:57:10 -0700 Received: from DE02WEMBXA.internal.synopsys.com ([fe80::a014:7216:77d:d55c]) by DE02WEHTCA.internal.synopsys.com ([::1]) with mapi id 14.03.0361.001; Mon, 23 Apr 2018 11:56:33 +0200 From: Claudiu Zissulescu To: Andrew Burgess CC: "gcc-patches@gcc.gnu.org" , "Francois.Bedard@synopsys.com" Subject: RE: [PATCH 2/5] [ARC] Fix FLS, SETI patterns. Date: Mon, 23 Apr 2018 10:34:00 -0000 Message-ID: <098ECE41A0A6114BB2A07F1EC238DE89667EF076@de02wembxa.internal.synopsys.com> References: <1523005214-1611-1-git-send-email-claziss@synopsys.com> <1523005214-1611-3-git-send-email-claziss@synopsys.com>,<20180418175727.GE3025@embecosm.com> In-Reply-To: <20180418175727.GE3025@embecosm.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2018-04/txt/msg01038.txt.bz2 Committed. Thank you for your review, Claudiu ________________________________________ From: Andrew Burgess [andrew.burgess@embecosm.com] Sent: Wednesday, April 18, 2018 7:57 PM To: Claudiu Zissulescu Cc: gcc-patches@gcc.gnu.org; Francois.Bedard@synopsys.com Subject: Re: [PATCH 2/5] [ARC] Fix FLS, SETI patterns. * Claudiu Zissulescu [2018-04-06 11:00:11= +0200]: > From: claziss > > Claudiu Zissulescu > > * config/arc/arc.md ("vunspec"): Delete it, unify all the unspec > enums into a single definition. > (fls): Fix predicates and printing. > (seti): Likewise. Looks good, Thanks, Andrew > --- > gcc/config/arc/arc.md | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md > index 2ec2b48..ffd9d5b 100644 > --- a/gcc/config/arc/arc.md > +++ b/gcc/config/arc/arc.md > @@ -137,9 +137,7 @@ > UNSPEC_ARC_VMPY2H > UNSPEC_ARC_VMPY2HU > UNSPEC_ARC_STKTIE > - ]) > > -(define_c_enum "vunspec" [ > VUNSPEC_ARC_RTIE > VUNSPEC_ARC_SYNC > VUNSPEC_ARC_BRK > @@ -5818,21 +5816,19 @@ archs4x, archs4xd, archs4xd_slow" > }) > > (define_insn "fls" > - [(set (match_operand:SI 0 "dest_reg_operand" "=3Dw,w") > - (unspec:SI [(match_operand:SI 1 "general_operand" "cL,Cal")] > + [(set (match_operand:SI 0 "register_operand" "=3Dr,r") > + (unspec:SI [(match_operand:SI 1 "nonmemory_operand" "rL,Cal")] > UNSPEC_ARC_FLS))] > "TARGET_NORM && TARGET_V2" > - "@ > - fls \t%0, %1 > - fls \t%0, %1" > + "fls\\t%0,%1" > [(set_attr "length" "4,8") > (set_attr "type" "two_cycle_core,two_cycle_core")]) > > (define_insn "seti" > - [(unspec_volatile:SI [(match_operand:SI 0 "general_operand" "rL")] > + [(unspec_volatile:SI [(match_operand:SI 0 "nonmemory_operand" "rL")] > VUNSPEC_ARC_SETI)] > "TARGET_V2" > - "seti %0" > + "seti\\t%0" > [(set_attr "length" "4") > (set_attr "type" "misc")]) > > -- > 1.9.1 >